feat(node): Remove multiple versions of types #3499

jkrvivian · 2024-10-21T12:15:01Z

Description of change

Remove multiple versions of types in the Move and Rust codebases, and start versioning from the latest type version.

Move

The renaming changes in accordance with the rules:

Add version postfix to those that will certainly be upgraded in the future.
No version postfix to those that won't be new version.
For the wrappers, we don't add Wrapper postfix.
For inner types, we don't add Inner, just add version postfix {structure}V1.

Structures with versioning:

SystemParametersV2 -> SystemParametersV1
IotaSystemStateWrapper -> IotaSystemState
IotaSystemStateInnerV2 -> IotaSystemStateV1
ValidatorWrapper -> Validator
Validator -> ValidatorV1
ValidatorMetadata -> ValidatorMetadataV1
ValidatorSet -> ValidatorSetV1
ValidatorEpochInfoEvent -> ValidatorEpochInfoEventV1
SystemEpochInfoEvent -> SystemEpochInfoEventV1
StakingPool -> StakingPoolV1
StorageFund -> StorageFundV1
VotingPowerInfoV2 -> VotingPowerInfoV1

Rust

Align type names to Move codes
Note: IotaSystemStateWrapper still exists and corresponds to IotaSystemState in Move. It's a thin wrapper for accessing the inner object and is rarely used in Rust. It's used only in genesis snapshots and testing, and in most cases, we use the enum IotaSystemState instead.
IotaSystemStateInnverV2 -> IotaSystemStateV1
ValidatorWrapper -> Validator
UnverifiedValidatorOperationCapV1 -> UnverifiedValidatorOperationCap

Links to any relevant issues

Close partially #1083

Type of change

Choose a type of change, and delete any options that are not relevant.

Breaking change

Change checklist

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes

…he iota-system types (#3048) * refactor(iota-framework/iota-system): Remove deprecated structures * refactor(iota-framework/iota-system): Rename ValidatorSet to ValidatorSetV1 * refactor(iota-framework/iota-system): Rename Validator to ValidatorV1 * refactor(iota-framework/iota-system): Rename ValidatorMetadata to ValidatorMetadataV1 * refactor(iota-framework/iota-system): Rename IotaSystemStateInnerV1 to IotaSystemStateV1 * refactor(iota-framework/iota-system): Rename SystemEpochInfoEvent to SystemEpochInfoEventV1 * refactor(iota-framework/iota-system): Rename StakingPool to StakingPoolV1 * refactor(iota-framework/iota-system): Rename PoolTokenExchangeRate to PoolTokenExchangeRateV1 * refactor(iota-framework/iota-system): Rename StakedIota to StakedIotaV1 * refactor(iota-framework/iota-system): Rename StorageFund to StorageFundV1 * refactor(iota-framework/iota-system): Rename TimelockedStakedIota to TimelockedStakedIotaV1 * refactor(iota-framework/iota-system): Rename IotaSystemStateInner to IotaSystemState in comments

* !chore(core-node): remove deprecated tables in `AuthorityEpochTables` * !chore(core-node): remove deprecated tables in `IndexStoreTables` * chore(scripts): add `target` to ignored_dirs

…ochTable` logic (#3139) * !chore(core-node): remove unused EpochFlags * !chore(core-node): remove ExecutedInEpochTable EpochFlag incl. special logic

…rStateUpdate` (#3173) * refactor(iota-types/authenticator-state): Rename AuthenticatorStateUpdate * refactor(iota-types/authenticator-state): Fix fmt and clippy

…o V1 or no suffix

…ersions

…igned_shared_object_versions

…mulatorV2` (#3524) * Remove StateAccumulatorV1 * Remove the state_accumulator_v2 always true logic * Rename state_accumulator_v2_enabled_config to be state_accumulator_config * Set the default state_accumulator_config * Rename with_state_accumulator_v2_enabled_callback to be with_state_accumulator_callback * Rename StateAccumulatorV2 to be StateAccumulatorV1 * clippy and fmt * Remove StateAccumulatorV1Enabled* flags

* Clean narwhal type versioning * Fix Batch::V2 to Batch::V1 in test

* Clean data types related to iota-e2e-tests * Rename ExecuteTransactionRequestV1::new_v2 to be new_v1

narwhal/types/src/primary.rs

…eat/remove-multiple-types

miker83z · 2024-10-24T17:19:59Z

d4ff63c fixes (this).
But now that it compiles, some simtests are failing.

github-actions · 2024-10-24T17:20:11Z