Skip to content

chore(core-node)!: remove deprecated db tables #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2024
Merged

chore(core-node)!: remove deprecated db tables #3142

merged 3 commits into from
Oct 14, 2024

Conversation

@muXxer
Copy link
Contributor

@muXxer muXxer commented Oct 8, 2024

Description of change

This PR removes deprecated database tables.
We need to reset the existing networks because that is a breaking change.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

I was running the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer requested review from a team as code owners October 8, 2024 15:16
@muXxer muXxer added the node Issues related to the Core Node team label Oct 8, 2024
@muXxer muXxer force-pushed the core-node/remove/deprecated-db-tables branch 2 times, most recently from fd9e606 to 677ea3b Compare October 8, 2024 17:16
@muXxer muXxer changed the base branch from develop to core-node/feat/remove-multiple-types October 9, 2024 09:17
@muXxer muXxer requested review from a team, miker83z and valeriyr as code owners October 9, 2024 09:17
@muXxer muXxer force-pushed the core-node/remove/deprecated-db-tables branch from 677ea3b to 293e728 Compare October 9, 2024 09:34
@bingyanglin
Copy link
Contributor

bingyanglin commented Oct 9, 2024 •
edited
Loading

Looks good. Just curious why the active_inputs: impl Iterator<Item = ObjectID>, is also removed in the IndexStore::index_tx? Is it because that the active_inputs is only used in the deprecated if branch if !self.remove_deprecated_tables {?

@muXxer
Copy link
Contributor Author

muXxer commented Oct 9, 2024

Looks good. Just curious why the active_inputs: impl Iterator<Item = ObjectID>, is also removed in the IndexStore::index_tx? Is it because that the active_inputs is only used in the deprecated if branch if !self.remove_deprecated_tables {?

yeah, that was my reasoning to remove it.

@DaughterOfMars DaughterOfMars changed the title !chore(core-node): remove deprecated db tables chore(core-node)!: remove deprecated db tables Oct 9, 2024
@jkrvivian jkrvivian force-pushed the core-node/feat/remove-multiple-types branch from 3b0f4fd to b98d4cd Compare October 14, 2024 07:10
@muXxer muXxer force-pushed the core-node/feat/remove-multiple-types branch 2 times, most recently from 6fb25d5 to 2a63305 Compare October 14, 2024 10:29
@muXxer muXxer force-pushed the core-node/remove/deprecated-db-tables branch from 293e728 to a6808ed Compare October 14, 2024 10:30
@miker83z miker83z requested review from kodemartin and removed request for miker83z and valeriyr October 14, 2024 10:50
kodemartin
kodemartin approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌸

@muXxer muXxer merged commit c101a58 into core-node/feat/remove-multiple-types Oct 14, 2024
25 of 33 checks passed
@muXxer muXxer deleted the core-node/remove/deprecated-db-tables branch October 14, 2024 15:25
muXxer added a commit that referenced this pull request Oct 21, 2024
@muXxer
chore(core-node)!: remove deprecated db tables (#3142)
23a5d0f 
* !chore(core-node): remove deprecated tables in `AuthorityEpochTables`

* !chore(core-node): remove deprecated tables in `IndexStoreTables`

* chore(scripts): add `target` to ignored_dirs
@daria305 daria305 mentioned this pull request Oct 30, 2024
Merged
2 tasks
muXxer added a commit that referenced this pull request Jan 28, 2025
@muXxer
fix: re-add rpc-indexes to support InputObject and ChangedObject …
da68323 
…filters (partly revert #3142)
muXxer added a commit that referenced this pull request Jan 29, 2025
@muXxer
fix: re-add rpc-indexes to support InputObject and ChangedObject …
0daa3f3 
…filters (partly revert #3142) (#5074)
lzpap pushed a commit that referenced this pull request Jan 29, 2025
@muXxer @lzpap
fix: re-add rpc-indexes to support InputObject and ChangedObject …
874504f 
…filters (partly revert #3142) (#5074)
lzpap added a commit that referenced this pull request Jan 30, 2025
@lzpap @muXxer
fix: re-add rpc-indexes to support InputObject and ChangedObject …
aed54b6 
…filters (partly revert #3142) (#5074) (#5088)

Co-authored-by: muXxer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piotrm50 piotrm50 piotrm50 approved these changes

@jkrvivian jkrvivian jkrvivian approved these changes

@kodemartin kodemartin kodemartin approved these changes

@bingyanglin bingyanglin bingyanglin approved these changes

Assignees

No one assigned

Labels

node Issues related to the Core Node team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@muXxer @bingyanglin @piotrm50 @jkrvivian @kodemartin