Skip to content

Conversation

@bingyanglin
Copy link
Contributor

@bingyanglin bingyanglin commented Oct 10, 2024

Closes #3096

Description of change

This PR renames the existing AuthenticatorStateUpdate to be AuthenticatorStateUpdateV1

There might be different AuthenticatorStateUpdate versions in the future, as there is a comment in iota-types/src/transaction.rs that says adding a AuthenticatorStateUpdateV2 to TransactionKind for versioning AuthenticatorStateUpdate.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

I was running the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin requested review from a team, miker83z and valeriyr as code owners October 10, 2024 02:46
@bingyanglin bingyanglin added the node Issues related to the Core Node team label Oct 10, 2024
@muXxer
Copy link
Contributor

muXxer commented Oct 10, 2024

Please don't forget run cargo +nightly fmt and cargo clippy --fix.

@bingyanglin bingyanglin marked this pull request as draft October 10, 2024 09:52
@bingyanglin bingyanglin changed the title refactor(iota-types/authenticator-state-update): Rename AuthenticatorStateUpdateV1 refactor(iota-types/authenticator-state-update): Rename AuthenticatorStateUpdate Oct 10, 2024
@bingyanglin
Copy link
Contributor Author

Please don't forget run cargo +nightly fmt and cargo clippy --fix.

Thanks for the reminding. Fixed at 3f2c74b.

@bingyanglin bingyanglin marked this pull request as ready for review October 10, 2024 14:26
@jkrvivian jkrvivian force-pushed the core-node/feat/remove-multiple-types branch from 3b0f4fd to b98d4cd Compare October 14, 2024 07:10
@muXxer muXxer force-pushed the core-node/feat/remove-multiple-types branch 2 times, most recently from 6fb25d5 to 2a63305 Compare October 14, 2024 10:29
@miker83z
Copy link
Contributor

@bingyanglin does it need a rebase?

@bingyanglin bingyanglin force-pushed the core-node/rename/authenticator-state-update branch from 3f2c74b to 959d0eb Compare October 14, 2024 11:34
@bingyanglin
Copy link
Contributor Author

bingyanglin commented Oct 14, 2024

@bingyanglin does it need a rebase?

Yes it needs. Done. But still needs to remove unused dependencies (also done).

@jkrvivian jkrvivian linked an issue Oct 14, 2024 that may be closed by this pull request
Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexsporn alexsporn merged commit e76605b into core-node/feat/remove-multiple-types Oct 14, 2024
26 of 33 checks passed
@alexsporn alexsporn deleted the core-node/rename/authenticator-state-update branch October 14, 2024 15:41
muXxer added a commit that referenced this pull request Oct 21, 2024
…rStateUpdate` (#3173)

* refactor(iota-types/authenticator-state): Rename AuthenticatorStateUpdate

* refactor(iota-types/authenticator-state): Fix fmt and clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename AuthenticatorStateUpdate and AuthenticatorStateUpdateV2

6 participants