-
Notifications
You must be signed in to change notification settings - Fork 58
refactor(iota-types/authenticator-state-update): Rename AuthenticatorStateUpdate
#3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iota-types/authenticator-state-update): Rename AuthenticatorStateUpdate
#3173
Conversation
|
Please don't forget run |
AuthenticatorStateUpdateV1AuthenticatorStateUpdate
Thanks for the reminding. Fixed at 3f2c74b. |
3b0f4fd to
b98d4cd
Compare
6fb25d5 to
2a63305
Compare
|
@bingyanglin does it need a rebase? |
3f2c74b to
959d0eb
Compare
Yes it needs. Done. But still needs to remove unused dependencies (also done). |
miker83z
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e76605b
into
core-node/feat/remove-multiple-types
…rStateUpdate` (#3173) * refactor(iota-types/authenticator-state): Rename AuthenticatorStateUpdate * refactor(iota-types/authenticator-state): Fix fmt and clippy
Closes #3096
Description of change
This PR renames the existing
AuthenticatorStateUpdateto beAuthenticatorStateUpdateV1There might be different
AuthenticatorStateUpdateversions in the future, as there is a comment iniota-types/src/transaction.rsthat says adding aAuthenticatorStateUpdateV2toTransactionKindfor versioningAuthenticatorStateUpdate.Type of change
How the change has been tested
I was running the local network with
RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucetChange checklist