Skip to content

Conversation

@bingyanglin
Copy link
Contributor

@bingyanglin bingyanglin commented Oct 15, 2024

Description of change

Clean up narwhal types

  • Renamed Batch::V2 and BatchV2 to be Batch::V1 and BatchV1
  • Renamed Certificate::V2 and CertificateV2 to be Certificate::V1 and CertificateV1

Note that the ConsensusCommit is indirectly used in ConsensusOutput, where current iota-core uses it. Might just keep them for now.

Links to any relevant issues

Fix #2096

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

  • I was running the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin self-assigned this Oct 15, 2024
@alexsporn alexsporn added the node Issues related to the Core Node team label Oct 15, 2024
@bingyanglin bingyanglin changed the title Clean narwhal type versioning refactor(narwhal-types): Clean narwhal type versioning Oct 15, 2024
@bingyanglin bingyanglin marked this pull request as ready for review October 16, 2024 01:58
@bingyanglin bingyanglin requested review from a team as code owners October 16, 2024 01:58
jkrvivian
jkrvivian previously approved these changes Oct 16, 2024
@bingyanglin bingyanglin force-pushed the core-node/feat/remove-multiple-types branch from 2a9e216 to e76605b Compare October 16, 2024 10:35
@alexsporn alexsporn dismissed jkrvivian’s stale review October 17, 2024 10:14

The PR changed after the review, so it needs another round

@muXxer muXxer force-pushed the core-node/feat/remove-multiple-types branch from e76605b to 619c048 Compare October 21, 2024 09:27
@muXxer muXxer requested review from a team, miker83z and valeriyr as code owners October 21, 2024 09:27
@muXxer muXxer force-pushed the core-node/rename/narwal-types branch from cae0d3d to a846f0d Compare October 21, 2024 09:54
@bingyanglin bingyanglin marked this pull request as draft October 22, 2024 08:34
@bingyanglin bingyanglin force-pushed the core-node/rename/narwal-types branch from edc78bc to fe2c7cf Compare October 23, 2024 06:03
@bingyanglin bingyanglin marked this pull request as ready for review October 23, 2024 06:07
@alexsporn alexsporn merged commit e351733 into core-node/feat/remove-multiple-types Oct 23, 2024
38 of 52 checks passed
@alexsporn alexsporn deleted the core-node/rename/narwal-types branch October 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants