Skip to content

Conversation

@bingyanglin
Copy link
Contributor

Description of change

  • Remove StateAccumulatorV1
    • remove notify_read_checkpoint_state_digests (only used in StateAccumulatorV1)
  • Remove the following always true logic
    • state_accumulator_v2_enabled
    • state_accumulator_v2 because it is now always true
    • with_state_accumulator_v2_enabled
  • Rename with_state_accumulator_v2_enabled_config to be with_state_accumulator_config
    • Note that now state_accumulator_v2 is always enabled and can be configured
  • Rename state_accumulator_v2_enabled_config to be state_accumulator_config
  • Rename validator_state_accumulator_v2_enabled_config to be validator_state_accumulator_config
  • Set the default state_accumulator_config to be Global(true)
  • Rename with_state_accumulator_v2_enabled_callback to be with_state_accumulator_callback

Links to any relevant issues

Closes #3259

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

  • I was running the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin requested review from a team as code owners October 22, 2024 07:32
@bingyanglin bingyanglin self-assigned this Oct 22, 2024
@alexsporn alexsporn added the node Issues related to the Core Node team label Oct 22, 2024

StateAccumulatorV2EnabledTestnet = 1,
StateAccumulatorV2EnabledMainnet = 2,
StateAccumulatorV1EnabledTestnet = 1,
Copy link
Member

@alexsporn alexsporn Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these flags and make it default behaviour.

Copy link
Contributor Author

@bingyanglin bingyanglin Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Those flags are removed in 494bcfd.
Also it was mad default behaviour like here, with commits 78fe7e6 and 3a1fde3.

@alexsporn alexsporn merged commit e9fe495 into core-node/feat/remove-multiple-types Oct 23, 2024
18 of 21 checks passed
@alexsporn alexsporn deleted the core-node/rename/state-accumulator branch October 23, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants