chore(core-node)!: remove unused EpochFlags + special ExecutedInEpochTable logic
#3139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
force-pushed
the
core-node/remove/deprecated-epoch-flags
branch
from
bc12654 to
96f0b62
Compare
DaughterOfMars
approved these changes
Oct 8, 2024
muXxer
changed the base branch from
develop
to
core-node/feat/remove-multiple-types
muXxer
force-pushed
the
core-node/remove/deprecated-epoch-flags
branch
2 times, most recently
from
d48b7b0 to
a8a5b04
Compare
bingyanglin
approved these changes
Oct 9, 2024
muXxer
changed the title
EpochFlags + special ExecutedInEpochTable logicEpochFlags + special ExecutedInEpochTable logic
jkrvivian
force-pushed
the
core-node/feat/remove-multiple-types
branch
from
3b0f4fd to
b98d4cd
Compare
muXxer
force-pushed
the
core-node/feat/remove-multiple-types
branch
2 times, most recently
from
6fb25d5 to
2a63305
Compare
muXxer
force-pushed
the
core-node/remove/deprecated-epoch-flags
branch
from
a8a5b04 to
e85499b
Compare
miker83z
approved these changes
Oct 14, 2024
Contributor
miker83z
left a comment
miker83z
left a comment
There was a problem hiding this comment.
Looks good, only a question:
Comment on lines
-1476
to
-1477
| // executed_in_epoch_table is enabled everywhere, we can remove the code below | ||
| // entirely. |
Contributor
There was a problem hiding this comment.
Do we have this assurance because we removed executed_in_epoch_table completely and the node is running?
Contributor
Author
There was a problem hiding this comment.
Yes it's the default setting since a long time in upstream, and for us it's enabled from the start.
muXxer
merged commit 0e8f219
into
core-node/feat/remove-multiple-types
26 of 33 checks passed
muXxer
added a commit
that referenced
this pull request
Oct 21, 2024
…ochTable` logic (#3139) * !chore(core-node): remove unused EpochFlags * !chore(core-node): remove ExecutedInEpochTable EpochFlag incl. special logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR removes unused EpochFlags.
I guess we need to reset the existing networks because that is a breaking change.
Type of change
How the change has been tested
I was running the local network with
RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucetChange checklist