Fix: Refactor PushToApplications and split into logic and GUI
#13514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PushToApplicationPreferences
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jabgui/src/main/java/org/jabref/gui/entryeditor/LatexCitationsTabViewModel.java
Outdated
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/push/GUIPushToApplications.java
Outdated
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/LatexCitationsTabViewModel.java
Outdated
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/push/GUIPushToApplications.java
Outdated
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/LatexCitationsTabViewModel.java
Outdated
Show resolved
Hide resolved
koppor
reviewed
Jul 9, 2025
jablib/src/main/java/org/jabref/logic/push/AbstractPushToApplication.java
Outdated
Show resolved
Hide resolved
palukku
changed the title
koppor
added
the
status: ready-for-review
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
approved these changes
Jul 11, 2025
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Jul 31, 2025
// endregion JabRef/jabref#13514 jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 1, 2025
// endregion JabRef/jabref#13514 jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java
Siedlerchr
added a commit
that referenced
this pull request
Aug 2, 2025
* upstream/main: Also label PR if good first issue is made (#13526) New Crowdin updates (#13529) chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.1 (#13528) chore: bump-okhttp-4.12.0-to-5.0.0 (#13521) Have the picker always on top (#13525) Refactor PushToApplications and split into logic and GUI (#13514) Add field to change HTTP port (#13479) Fix trigger of comment Use Java 11 isBlank (#13523) Add run openrewrite (#13524) Comment ion PR just opened (#13522) Improve merge logic to prefer valid year and entry type (#13506) Update dependency com.konghq:unirest-modules-gson to v4.4.12 (#13517) Add rpm target (#13516) Revert module name changes for remaining 'unnamed' Jars (#13515) fix: revert Java module names to restore Status Log compatibility in JabRef 5.15 (#13511) update java vendor in devcontainer and sdkmanrc (#13513)
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Aug 4, 2025
JabRef/jabref#13514 Rename Attribute dialogService : DialogService to notificationService : NotificationService in class org.jabref.logic.push.AbstractPushToApplication Eliminate false Push Down Attribute refactorings
palukku
changed the title
PushToApplications and split into logic and GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes palukku#4
I moved the logic parts from the PushToApplications from gui to logic and added GUI... to the classes relevant for the GUI.
Steps to test
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)