Skip to content

Conversation

@Munhangyeol
Copy link
Contributor

@Munhangyeol Munhangyeol commented Jul 8, 2025

Closes #13509

Summary of Changes

This pull request reverts several module names in module-info.java and related Gradle configurations back to their previous values to ensure compatibility and maintain consistency with the existing codebase and dependencies.

Steps to test

  1. Build the project using ./gradlew clean build and verify there are no module-related errors.
  2. Run the application and confirm that the modules load correctly without runtime issues.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One of the fastest PRs I saw! Congratulations!

@koppor koppor added this pull request to the merge queue Jul 8, 2025
@Munhangyeol
Copy link
Contributor Author

Thanks! It’s all thanks to your clear explanation of the issue. Appreciate it :)

@koppor koppor removed this pull request from the merge queue due to a manual request Jul 9, 2025
@koppor koppor added this pull request to the merge queue Jul 9, 2025
@koppor
Copy link
Member

koppor commented Jul 9, 2025

Thanks! It’s all thanks to your clear explanation of the issue. Appreciate it :)

I spend several hours with this setting. Based on that knowledge, I could craft an explanation 😅

@koppor koppor removed this pull request from the merge queue due to a manual request Jul 9, 2025
@koppor koppor enabled auto-merge July 9, 2025 06:42
@koppor
Copy link
Member

koppor commented Jul 9, 2025

@Munhangyeol Maybe you could also take a look at this one #13456?

@trag-bot
Copy link

trag-bot bot commented Jul 9, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue Jul 9, 2025
Merged via the queue into JabRef:main with commit 0848124 Jul 9, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 9, 2025
@Munhangyeol
Copy link
Contributor Author

@koppor I have something scheduled for today, so would it be okay if I work on it by tomorrow or the day after?

@koppor
Copy link
Member

koppor commented Jul 9, 2025

@koppor I have something scheduled for today, so would it be okay if I work on it by tomorrow or the day after?

Sure!

I will close that PR - you can just checkout latest upstream/main, create a new branch and apply https://github.com/JabRef/jabref/pull/13456/files manually - and then try to get it fixed :)

Siedlerchr added a commit that referenced this pull request Aug 2, 2025
* upstream/main:
  Also label PR if good first issue is made (#13526)
  New Crowdin updates (#13529)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.1 (#13528)
  chore: bump-okhttp-4.12.0-to-5.0.0 (#13521)
  Have the picker always on top (#13525)
  Refactor PushToApplications and split into logic and GUI (#13514)
  Add field to change HTTP port (#13479)
  Fix trigger of comment
  Use Java 11 isBlank (#13523)
  Add run openrewrite (#13524)
  Comment ion PR just opened (#13522)
  Improve merge logic to prefer valid year and entry type (#13506)
  Update dependency com.konghq:unirest-modules-gson to v4.4.12 (#13517)
  Add rpm target (#13516)
  Revert module name changes for remaining 'unnamed' Jars (#13515)
  fix: revert Java module names to restore Status Log compatibility in JabRef 5.15 (#13511)
  update java vendor in devcontainer and sdkmanrc (#13513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change module names

2 participants