-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: revert Java module names to restore Status Log compatibility in JabRef 5.15 #13511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One of the fastest PRs I saw! Congratulations!
|
Thanks! It’s all thanks to your clear explanation of the issue. Appreciate it :) |
I spend several hours with this setting. Based on that knowledge, I could craft an explanation 😅 |
|
@Munhangyeol Maybe you could also take a look at this one #13456? |
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
@koppor I have something scheduled for today, so would it be okay if I work on it by tomorrow or the day after? |
Sure! I will close that PR - you can just checkout latest |
* upstream/main: Also label PR if good first issue is made (#13526) New Crowdin updates (#13529) chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.1 (#13528) chore: bump-okhttp-4.12.0-to-5.0.0 (#13521) Have the picker always on top (#13525) Refactor PushToApplications and split into logic and GUI (#13514) Add field to change HTTP port (#13479) Fix trigger of comment Use Java 11 isBlank (#13523) Add run openrewrite (#13524) Comment ion PR just opened (#13522) Improve merge logic to prefer valid year and entry type (#13506) Update dependency com.konghq:unirest-modules-gson to v4.4.12 (#13517) Add rpm target (#13516) Revert module name changes for remaining 'unnamed' Jars (#13515) fix: revert Java module names to restore Status Log compatibility in JabRef 5.15 (#13511) update java vendor in devcontainer and sdkmanrc (#13513)
Closes #13509
Summary of Changes
This pull request reverts several module names in
module-info.javaand related Gradle configurations back to their previous values to ensure compatibility and maintain consistency with the existing codebase and dependencies.Steps to test
./gradlew clean buildand verify there are no module-related errors.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)