Skip to content

Use Java 11 isBlank #13523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2025
Merged

Use Java 11 isBlank #13523

merged 3 commits into from
Jul 10, 2025

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jul 10, 2025

Since Java 11, there is isBlank. - https://stackoverflow.com/q/51299126/873282.

No need for Apache Commons usage here.

Triggered by #13519

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Jul 10, 2025
subhramit
subhramit previously approved these changes Jul 10, 2025
View reviewed changes
@subhramit
Copy link
Member

subhramit commented Jul 10, 2025

openrewrite

@koppor koppor mentioned this pull request Jul 10, 2025
Merged
1 task
@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label Jul 10, 2025
@koppor koppor enabled auto-merge July 10, 2025 08:49
@trag-bot
Copy link

trag-bot bot commented Jul 10, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 5d9b6ac Jul 10, 2025
2 checks passed
@koppor koppor deleted the modernize-is-blank branch July 10, 2025 09:23
Siedlerchr added a commit that referenced this pull request Aug 2, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
bf98fba 
* upstream/main:
  Also label PR if good first issue is made (#13526)
  New Crowdin updates (#13529)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.1 (#13528)
  chore: bump-okhttp-4.12.0-to-5.0.0 (#13521)
  Have the picker always on top (#13525)
  Refactor PushToApplications and split into logic and GUI (#13514)
  Add field to change HTTP port (#13479)
  Fix trigger of comment
  Use Java 11 isBlank (#13523)
  Add run openrewrite (#13524)
  Comment ion PR just opened (#13522)
  Improve merge logic to prefer valid year and entry type (#13506)
  Update dependency com.konghq:unirest-modules-gson to v4.4.12 (#13517)
  Add rpm target (#13516)
  Revert module name changes for remaining 'unnamed' Jars (#13515)
  fix: revert Java module names to restore Status Log compatibility in JabRef 5.15 (#13511)
  update java vendor in devcontainer and sdkmanrc (#13513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jabref-machine jabref-machine jabref-machine approved these changes

@subhramit subhramit subhramit left review comments

Assignees

No one assigned

Labels

automerge PR is tagged with that label will be merged if workflows are green dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koppor @subhramit @jabref-machine