Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jul 10, 2025

Triggered by #13500

If a contributor "just" submits a PR on fixing an issue, we cannot mark the issue to the contributor. Thus other contributors can assign it to themselves (happened at #13486 (comment)).

To avoid that, we can post a message to the PR at these cases.

This is somehow different to other projects, where a PR can be made without "raising hands". In our context 90% of the contributors come. Therefore, the workflow job will only fail on non good first/second/... issues.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@trag-bot
Copy link

trag-bot bot commented Jul 10, 2025

@trag-bot didn't find any issues in the code! ✅✨

@subhramit
Copy link
Member

subhramit commented Jul 10, 2025

So this basically means - no auto-assignment on direct PRs (corresponding to an issue), trigger message on PR to tell the contributor to assign themselves first

@koppor
Copy link
Member Author

koppor commented Jul 10, 2025

So this basically means - no auto-assignment on direct PRs (corresponding to an issue), trigger message on PR to tell the contributor to assign themselves first

Partially: Auto assignment if contributor commented on issue. If contributor did not comment, tell him to assign himself (in the case of good first issue). Otherwise: Stay silent.

@subhramit subhramit added this pull request to the merge queue Jul 10, 2025
@subhramit subhramit changed the title Comment ion PR just opened Comment on PR just opened Jul 10, 2025
Merged via the queue into main with commit 9392108 Jul 10, 2025
1 of 2 checks passed
@subhramit subhramit deleted the add-assign-comment branch July 10, 2025 06:09
Siedlerchr added a commit that referenced this pull request Aug 2, 2025
* upstream/main:
  Also label PR if good first issue is made (#13526)
  New Crowdin updates (#13529)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.1 (#13528)
  chore: bump-okhttp-4.12.0-to-5.0.0 (#13521)
  Have the picker always on top (#13525)
  Refactor PushToApplications and split into logic and GUI (#13514)
  Add field to change HTTP port (#13479)
  Fix trigger of comment
  Use Java 11 isBlank (#13523)
  Add run openrewrite (#13524)
  Comment ion PR just opened (#13522)
  Improve merge logic to prefer valid year and entry type (#13506)
  Update dependency com.konghq:unirest-modules-gson to v4.4.12 (#13517)
  Add rpm target (#13516)
  Revert module name changes for remaining 'unnamed' Jars (#13515)
  fix: revert Java module names to restore Status Log compatibility in JabRef 5.15 (#13511)
  update java vendor in devcontainer and sdkmanrc (#13513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants