Remove id attribute from RouteChangeAnnouncement component #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kent C. Dodds <[email protected]>
fix: pass full request to handleDataRequest, not stripped
…run#620) Co-authored-by: Kent C. Dodds <[email protected]>
Co-authored-by: Kent C. Dodds <[email protected]>
Co-authored-by: Kent C. Dodds <[email protected]>
|
Hi @matmilbury, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
matmilbury
force-pushed
the
discussion-763-remove-id
branch
from
d8da334 to
b161865
Compare
kentcdodds
force-pushed
the
dev
branch
2 times, most recently
from
ab9dac4 to
172ecc9
Compare
|
we no longer have that in the template, but thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#763
tldr; the id attribute is not referenced anywhere, it seems it has no purpose.