refactor: use ternaries rather than && in JSX #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if casting to a boolean and keeping the |
MichaelDeBoey
force-pushed
the
use-ternaries-instead-of-and-and
branch
from
1cafc8c to
400f6be
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
force-pushed
the
use-ternaries-instead-of-and-and
branch
2 times, most recently
from
bab5b89 to
a5cd85f
Compare
MichaelDeBoey
force-pushed
the
use-ternaries-instead-of-and-and
branch
from
a5cd85f to
0621074
Compare
kentcdodds
approved these changes
Nov 29, 2021
|
Oh rats. I just realized a few of these have highlighted lines that will be off based on this change. @MichaelDeBoey, do you think you could take a minute to check and fix any highlighted lines that broke as a result of this change? |
|
@kentcdodds I'll look into this and create a separate PR 👍 |
kentcdodds
pushed a commit
that referenced
this pull request
Nov 30, 2021
kentcdodds
pushed a commit
that referenced
this pull request
Dec 1, 2021
kentcdodds
pushed a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make @kentcdodds happy
https://kentcdodds.com/blog/use-ternaries-rather-than-and-and-in-jsx