chore(create-remix): simplify Netlify template #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
approved these changes
Nov 25, 2021
Contributor
|
awesome @ascorbic! I missed this quickly combing through the issues this morning, we'll get this released soon! |
mcansh
approved these changes
Nov 26, 2021
mcansh
changed the title
kentcdodds
pushed a commit
that referenced
this pull request
Nov 30, 2021
ikhattab
pushed a commit
to ikhattab/remix
that referenced
this pull request
Nov 30, 2021
kentcdodds
pushed a commit
that referenced
this pull request
Dec 1, 2021
kentcdodds
pushed a commit
that referenced
this pull request
Dec 2, 2021
ikhattab
pushed a commit
to ikhattab/remix
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We've updated the Netlify CLI to make the DX better for Remix, removing the need to run two commands. This PR updates the template to add the new instructions and configuration.
We will soon be adding auto-detection for Remix too, which will remove the need for most of the configuration too. I will do another PR when that is ready.
Keep up the great work!