Skip to content

Conversation

@MichaelDeBoey
Copy link
Member

As requested by @kentcdodds in his Remix Tutorial stream

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 23, 2021

Hi @MichaelDeBoey,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 23, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title chore: fix actions.tsx chore: fix actions demo Nov 23, 2021
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev November 23, 2021 16:38
@MichaelDeBoey MichaelDeBoey force-pushed the patch-2 branch 2 times, most recently from cf6cd5d to a6e4e56 Compare November 23, 2021 16:44
@MichaelDeBoey MichaelDeBoey mentioned this pull request Nov 24, 2021
@MichaelDeBoey MichaelDeBoey force-pushed the patch-2 branch 3 times, most recently from 7dad380 to 2e81ddd Compare November 24, 2021 22:57
Comment on lines 26 to 34
let rightAnswers = [
"4fa6024f12494d3a99d8bda9b7a55f7d140f328a",
"ce3659ad235ca6d1e12dec21465aff3f9a62bb8c",
"bd111dcb4b343de4ec0a79d2d5ec55a3919c79c4"
];

let encrypted = hash(answer);

if (!rightAnswers.includes(encrypted)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this difference from the template was intentional. I'll go ahead and restore this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were deleted from the templates by @ryanflorence in #462, so that's why I deleted it here too.

I'll create a separate PR to delete it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds Here you go: #779

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 2f6fff8 into remix-run:dev Nov 29, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-2 branch November 29, 2021 18:27
kentcdodds added a commit that referenced this pull request Nov 30, 2021
Co-authored-by: Kent C. Dodds <[email protected]>
kentcdodds added a commit that referenced this pull request Dec 1, 2021
Co-authored-by: Kent C. Dodds <[email protected]>
kentcdodds added a commit that referenced this pull request Dec 2, 2021
Co-authored-by: Kent C. Dodds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants