-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore: fix actions demo #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @MichaelDeBoey, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
57baf4f to
74710c3
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
cf6cd5d to
a6e4e56
Compare
7dad380 to
2e81ddd
Compare
2e81ddd to
55211b3
Compare
| let rightAnswers = [ | ||
| "4fa6024f12494d3a99d8bda9b7a55f7d140f328a", | ||
| "ce3659ad235ca6d1e12dec21465aff3f9a62bb8c", | ||
| "bd111dcb4b343de4ec0a79d2d5ec55a3919c79c4" | ||
| ]; | ||
|
|
||
| let encrypted = hash(answer); | ||
|
|
||
| if (!rightAnswers.includes(encrypted)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling this difference from the template was intentional. I'll go ahead and restore this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were deleted from the templates by @ryanflorence in #462, so that's why I deleted it here too.
I'll create a separate PR to delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kentcdodds Here you go: #779
kentcdodds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Kent C. Dodds <[email protected]>
Co-authored-by: Kent C. Dodds <[email protected]>
Co-authored-by: Kent C. Dodds <[email protected]>
As requested by @kentcdodds in his Remix Tutorial stream