AMRNAV-6339 Enable IPC for rosbag recorder and foxglove bridge: Support IPC for serialized subscribers #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added rclcpp::SerializedMessage support for AnySubscriptionCallback Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> * using AnySubscription callback for generic subscriptiion Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> * updated tests Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> * Remove comment Signed-off-by: Joshua Hampp <[email protected]> --------- Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> Co-authored-by: Joshua Hampp <[email protected]> Co-authored-by: Jacob Perron <[email protected]>
commit a8e279c Author: Joshua Hampp <[email protected]> Date: Mon Dec 11 15:52:34 2023 +0100 added test for SubscriptionIntraProcess with unique subscriber Signed-off-by: Joshua Hampp <[email protected]> commit 4f6e466 Author: Joshua Hampp <[email protected]> Date: Mon Dec 11 15:51:54 2023 +0100 extended test for shared callback to cover more use cases Signed-off-by: Joshua Hampp <[email protected]> commit 2115b26 Author: Joshua Hampp <[email protected]> Date: Mon Dec 11 14:11:21 2023 +0100 added test_intra_process_subscriber to test serialized communication with IPM Signed-off-by: Joshua Hampp <[email protected]> commit 9d37234 Author: Joshua Hampp <[email protected]> Date: Mon Nov 6 07:17:36 2023 +0100 updated SubscriptionTopicStatistics to current master Signed-off-by: Joshua Hampp <[email protected]> commit 280e7be Author: Joshua Hampp <[email protected]> Date: Mon May 22 11:18:02 2023 +0200 updated to rolling Signed-off-by: Joshua Hampp <[email protected]> commit 16fc15f Author: Joshua Hampp <[email protected]> Date: Mon May 8 13:53:30 2023 +0200 fixes due to rebase Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 3978f2a Author: Joshua Hampp <[email protected]> Date: Wed Aug 3 09:21:21 2022 +0200 added unit test for generic publisher/subscriber with intraprocess communication Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 245c868 Author: Joshua Hampp <[email protected]> Date: Mon Aug 1 13:03:43 2022 +0200 fixed duplicated messages for ipm and serialized messages Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit e98c158 Author: Joshua Hampp <[email protected]> Date: Thu Jul 7 08:42:48 2022 +0200 added additional methods for create_generic_subscription Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit c2501cf Author: Joshua Hampp <[email protected]> Date: Thu Jul 7 08:14:41 2022 +0200 updated test to ipm issue Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit c9b148b Author: Joshua Hampp <[email protected]> Date: Thu Jul 7 08:14:18 2022 +0200 throwing error when subscription callback uses rclcpp::SerializedMessage and subscriber has a ros message type for intra process communication Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 667d8d2 Author: Joshua Hampp <[email protected]> Date: Thu Jul 7 08:13:15 2022 +0200 fixed intra process publish of serialized message Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 048c458 Author: Joshua Hampp <[email protected]> Date: Thu Jun 23 08:41:59 2022 +0200 using instead of typedef Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 098b6dd Author: Joshua Hampp <[email protected]> Date: Thu Jun 23 08:41:48 2022 +0200 splitted deserialization and message forwarding Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 158ab2c Author: Joshua Hampp <[email protected]> Date: Wed Jun 22 11:44:44 2022 +0200 removed specialization of GenericSubscription Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 7880677 Author: Joshua Hampp <[email protected]> Date: Wed Jun 22 10:30:15 2022 +0200 fix double return Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit b4236b3 Author: Joshua Hampp <[email protected]> Date: Mon Jun 20 11:04:43 2022 +0200 enabled qos override Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit f45d12b Author: Joshua Hampp <[email protected]> Date: Mon Jun 20 11:04:24 2022 +0200 added failure case at top Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit ea9245e Author: Joshua Hampp <[email protected]> Date: Mon Jun 20 11:03:37 2022 +0200 added comment block Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 795a281 Author: Joshua Hampp <[email protected]> Date: Mon Jun 20 11:02:25 2022 +0200 fixed comment Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit de29d0e Author: Joshua Hampp <[email protected]> Date: Mon Jun 20 07:46:27 2022 +0200 renamed to Indices Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 9e16b43 Author: DensoADAS <[email protected]> Date: Mon Jun 20 08:10:57 2022 +0200 Update rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp Signed-off-by: Joshua Hampp <[email protected]> Co-authored-by: Jacob Perron <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 9b5fd63 Author: DensoADAS <[email protected]> Date: Mon Jun 20 08:10:50 2022 +0200 Update rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp Signed-off-by: Joshua Hampp <[email protected]> Co-authored-by: Jacob Perron <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 4cbc678 Author: Joshua Hampp <[email protected]> Date: Tue May 17 09:02:15 2022 +0200 using const modifier Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit c8fd558 Author: Joshua Hampp <[email protected]> Date: Tue May 17 09:02:05 2022 +0200 updated comments Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 4a34d97 Author: Joshua Hampp <[email protected]> Date: Tue May 17 09:01:45 2022 +0200 renamed to SplitSubscriptionsIndices and changed datatype to unsigned Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit bb09e50 Author: Joshua Hampp <[email protected]> Date: Fri May 13 10:27:52 2022 +0200 added ipm for generic_subscription Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 2a28f60 Author: Joshua Hampp <[email protected]> Date: Fri May 13 10:27:34 2022 +0200 updated tests Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 18c9259 Author: Joshua Hampp <[email protected]> Date: Thu May 12 14:28:25 2022 +0200 updated tests Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 1f1f28f Author: Joshua Hampp <[email protected]> Date: Thu May 12 14:28:03 2022 +0200 updated publisher/subcription factories Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 33cb9dc Author: Joshua Hampp <[email protected]> Date: Thu May 12 14:27:41 2022 +0200 * publish std::unique_ptr<rclcpp::SerializedMessage> support with ipm * publisher constructor with message type support Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]> commit 636e076 Author: Joshua Hampp <[email protected]> Date: Thu May 12 14:26:20 2022 +0200 added rclcpp::SerializedMessage support to IPM Signed-off-by: Joshua Hampp <[email protected]> Signed-off-by: Joshua Hampp <[email protected]>
HovorunB
changed the title
This was referenced Feb 16, 2024
jplapp
approved these changes
Feb 16, 2024
HovorunB
added a commit
that referenced
this pull request
Mar 14, 2024
AMRNAV-6339 Enable IPC for rosbag recorder and foxglove bridge: Support IPC for serialized subscribers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
ros2#1928
ros2#1931