[core] Deprecate undefined type and use dynamic where possible #28766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Raasz <[email protected]>
praasz
requested review from
ilya-lavrenov and
itikhono
and removed request for
a team
github-actions
bot
added
category: inference
…-dynamic-instead-undefined
|
@vladimir-paramuzov , @dmitry-gorokhov , @PatrikStepan friendly reminder |
p-durandin
reviewed
Feb 14, 2025
src/plugins/intel_gpu/include/intel_gpu/primitives/primitive.hpp
Outdated
Show resolved
Hide resolved
- remove code duplicate Signed-off-by: Raasz, Pawel <[email protected]>
…-dynamic-instead-undefined
Signed-off-by: Raasz, Pawel <[email protected]>
…-dynamic-instead-undefined
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
t-jankowski
deleted the
feature/use-element-dynamic-instead-undefined
branch
Merged
|
Some NPU regressions were added with this PR: Compilation fails for IntelDNS |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
### Details: - to be merged after: #28766 ### Tickets: - [CVS-161723](https://jira.devtools.intel.com/browse/CVS-161723)
timxu826
pushed a commit
to timxu826/openvino
that referenced
this pull request
Apr 7, 2025
### Details: - to be merged after: openvinotoolkit#28766 ### Tickets: - [CVS-161723](https://jira.devtools.intel.com/browse/CVS-161723)
abrown
added a commit
to abrown/openvino-rs
that referenced
this pull request
Jun 10, 2025
OpenVINO 2025.1.0 deprecates `ov_element_type_e::UNDEFINED` ([#28766]), so this change removes it in the Rust bindings. This does create a breaking API change across minor versions of upstream OpenVINO (v2025.0 to v2025.1); we should assume from here on out that the C API is unstable. [#28766]: openvinotoolkit/openvino#28766
abrown
added a commit
to abrown/openvino-rs
that referenced
this pull request
Jun 10, 2025
OpenVINO 2025.1.0 deprecates `ov_element_type_e::UNDEFINED` ([#28766]), so this change removes it in the Rust bindings. This does create a breaking API change across minor versions of upstream OpenVINO (v2025.0 to v2025.1); we should assume from here on out that the C API is unstable. [#28766]: openvinotoolkit/openvino#28766
rahulchaphalkar
pushed a commit
to intel/openvino-rs
that referenced
this pull request
Jun 10, 2025
* Update `upstream` submodule to v2025.1.0 This captures (minus some cleanup of now-untracked files): ``` cd crates/openvino-sys/upstream git checkout 2025.1.0 git submodule update --init --recursive ``` This brings the upstream submodule in line with release [2025.1.0]. [2025.1.0]: https://github.com/openvinotoolkit/openvino/releases/tag/2025.1.0 * Update bindings This captures: ``` cargo xtask codegen ``` The key change introduced here--a breaking one--is the rearranging of all of the enum values for `ov_element_type_e`. Like #143, this creates an incompatibility when running a pre-2025.1 OpenVINO with this version of the bindings. * Remove `RwPropertyKey::Affinity` This pulls in work from #159 to remove a now-unknown property. Co-authored-by: Rickvanderveen <[email protected]> * Remove `ElementType::Undefined` OpenVINO 2025.1.0 deprecates `ov_element_type_e::UNDEFINED` ([#28766]), so this change removes it in the Rust bindings. This does create a breaking API change across minor versions of upstream OpenVINO (v2025.0 to v2025.1); we should assume from here on out that the C API is unstable. [#28766]: openvinotoolkit/openvino#28766 * ci: temporarily limit the versions tested in CI --------- Co-authored-by: Rickvanderveen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
### Details: > #28766 mark UNDEFINED type as deprecated. Need to add UNDEFINED type test on openvino to find compatibility issue earlier. > Added a test case to verify whether the serialization, compilation and inference results of the undefined type model and the dynamic type model are the same. ### Tickets: - *E-162769*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
ov::element::undefinedas deprecatedRelated PRs:
Tickets: