Skip to content

Conversation

@DanLiu2Intel
Copy link
Contributor

@DanLiu2Intel DanLiu2Intel commented Jul 3, 2025

Details:

#28766 mark UNDEFINED type as deprecated. Need to add UNDEFINED type test on openvino to find compatibility issue earlier.
Added a test case to verify whether the serialization, compilation and inference results of the undefined type model and the dynamic type model are the same.

Tickets:

  • E-162769

@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Jul 3, 2025
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch 2 times, most recently from 882e0d3 to 5f1f784 Compare July 7, 2025 13:27
@DanLiu2Intel DanLiu2Intel marked this pull request as ready for review July 8, 2025 03:05
@DanLiu2Intel DanLiu2Intel requested review from a team as code owners July 8, 2025 03:05
@DanLiu2Intel DanLiu2Intel marked this pull request as draft July 9, 2025 02:26
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch from 5444251 to 06aeb0c Compare July 10, 2025 06:33
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch from 058bbca to e371163 Compare July 10, 2025 07:15
@DanLiu2Intel DanLiu2Intel marked this pull request as ready for review July 10, 2025 07:23
@DanLiu2Intel DanLiu2Intel marked this pull request as draft July 10, 2025 07:47
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch 3 times, most recently from 561ffdf to c982881 Compare July 11, 2025 10:38
@DanLiu2Intel DanLiu2Intel marked this pull request as ready for review July 12, 2025 05:29
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch from c982881 to cb137a9 Compare July 12, 2025 05:32
@XinWangIntel XinWangIntel requested a review from praasz July 15, 2025 05:40
@XinWangIntel
Copy link
Contributor

@praasz we add test to check regression of UNDEFINED type and DYNAMIC type for NPU, could you help to review this?

@praasz
Copy link
Contributor

praasz commented Jul 23, 2025

@praasz we add test to check regression of UNDEFINED type and DYNAMIC type for NPU, could you help to review this?

@DanLiu2Intel
Is good to have such test but check if there are any in:
src/frontends/ir/tests/frontend_test_basic.cpp

or any other files in this folder src/frontends/ir/tests/

Please check the test:
TEST_F(IRFrontendTests, elementary_model_reading_v11_undefined_precisoin)

Expand/add new there to cover new case.

There is also test:
TEST(element_type, from_string)

in:
src/core/tests/element_type.cpp

@DanLiu2Intel DanLiu2Intel requested a review from a team as a code owner July 24, 2025 07:24
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Jul 24, 2025
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch from b0ee89f to 585be9b Compare July 28, 2025 01:20
@praasz praasz added this to the 2025.3 milestone Jul 28, 2025
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch from d3441ad to 66646db Compare July 28, 2025 08:45
@DanLiu2Intel DanLiu2Intel force-pushed the add_undefined_test_for_npudriver_compatibility branch from 66646db to 5c4d7cc Compare July 28, 2025 08:52
@PatrikStepan PatrikStepan added this pull request to the merge queue Jul 31, 2025
Merged via the queue into openvinotoolkit:master with commit f28176b Jul 31, 2025
246 of 250 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Core OpenVINO Core (aka ngraph) category: NPU OpenVINO NPU plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants