Upgrade bindings to v2025.1.0 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This captures (minus some cleanup of now-untracked files): ``` cd crates/openvino-sys/upstream git checkout 2025.1.0 git submodule update --init --recursive ``` This brings the upstream submodule in line with release [2025.1.0]. [2025.1.0]: https://github.com/openvinotoolkit/openvino/releases/tag/2025.1.0
This captures: ``` cargo xtask codegen ``` The key change introduced here--a breaking one--is the rearranging of all of the enum values for `ov_element_type_e`. Like intel#143, this creates an incompatibility when running a pre-2025.1 OpenVINO with this version of the bindings.
This pulls in work from intel#159 to remove a now-unknown property. Co-authored-by: Rickvanderveen <[email protected]>
OpenVINO 2025.1.0 deprecates `ov_element_type_e::UNDEFINED` ([#28766]), so this change removes it in the Rust bindings. This does create a breaking API change across minor versions of upstream OpenVINO (v2025.0 to v2025.1); we should assume from here on out that the C API is unstable. [#28766]: openvinotoolkit/openvino#28766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes some of the work by @Rickvanderveen in #159 (thanks!) and makes the crate compatible with OpenVINO v2025.1.0 and above. I've documented the breaking ABI change from upstream in #167 and will follow this up with a fix to only allow this code to work with versions 2025.1.0 and above.