[CORE] Try to correct 'undefined' and 'dynamic' type serialization #28524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorDuplensky
force-pushed
the
try_to_correct_element_type_serialization
branch
from
b16492a to
799051c
Compare
praasz
reviewed
Jan 22, 2025
| return "undefined"; | ||
| case ::ov::element::Type_t::dynamic: | ||
| return "UNSPECIFIED"; | ||
| return "dynamic"; |
There was a problem hiding this comment.
Can you some simple test(s) in:
- one of file in:
src/core/tests/pass/serialization/ src/frontends/ir/tests/frontend_test_basic.cppto check de-serialization also works
|
After merge of #28766 this change will be not required as underdefined and dynamic is same type and undefined will be remove in 2026.0 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
### Details: - Mark `ov::element::undefined` as deprecated - Use dynamic type instead of undefined ### Related PRs: - openvinotoolkit/openvino_contrib#945 - #28524 ### Tickets: - CVS-161637 --------- Signed-off-by: Pawel Raasz <[email protected]> Signed-off-by: Raasz, Pawel <[email protected]>
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR was closed because it has been stalled for 2 week with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
and the ir serializer itself.
After introduction of internal opset FullyConnected operation the 'undefined' element type basically
became valid and serializable