fix(networkmonitor): false engine restarts #3355
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please do not merge until go-netroute gets updated and merged. |
lixmal
reviewed
Feb 20, 2025
hurricanehrndz
force-pushed
the
fix_networkmonitor_false_enginerestarts
branch
from
a238f3e to
91dd571
Compare
lixmal
reviewed
Feb 20, 2025
Contributor
Author
|
With the newest changes, this is the log when I pull out my usb-c wired connection |
Contributor
Author
|
Once the go-netroute PR is merge I can update the go.mod file |
Currently, check_change registers a change whenever an unspecified address is removed or added on any interface. It should only register a change when it is the default route that is affected by route changes.
hurricanehrndz
force-pushed
the
fix_networkmonitor_false_enginerestarts
branch
from
973363f to
0190ed4
Compare
|
Contributor
Author
|
@pappz @lixmal I have updated the PR to resolve any conflicts. Can you please review. This patch still needs this PR: netbirdio/go-netroute#5 |
…false_enginerestarts * upstream/main: (228 commits) [management] add breakdown of network map calculation metrics (netbirdio#4020) [client] Don't open cmd.exe during MSI actions (netbirdio#4041) [misc] Specify netbird binary location in Dockerfiles (netbirdio#4024) [management] check and log on new management version (netbirdio#4029) [misc] add additional metrics (netbirdio#4028) [client] close windows when process needs to exit (netbirdio#4027) [client] Refactor showLoginURL to improve error handling and connection status checks (netbirdio#4026) [client] Handle lazy routing peers that are part of HA groups (netbirdio#3943) [management] add transaction for integrated validator groups update and primary account update (netbirdio#4014) [management] export ephemeral peer flag on api (netbirdio#4004) [management] Add backward compatibility for older clients without firewall rules port range support (netbirdio#4003) [client] Fix port range squashing (netbirdio#4007) [client] Add more Android advanced settings (netbirdio#4001) Fix route notification [management] Refactor routes to use store methods (netbirdio#2928) [client] fix connection state handling (netbirdio#3995) [client] Fix logic in updateStatus to correctly handle connection state (netbirdio#3994) [management] Avoid recalculating next peer expiration (netbirdio#3991) [client] Fix DNS Interceptor Build Error (netbirdio#3993) [client] Tighten allowed domains for dns forwarder (netbirdio#3978) ...
hurricanehrndz
force-pushed
the
fix_networkmonitor_false_enginerestarts
branch
from
b8eff53 to
96cd3e0
Compare
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Network monitor should only trigger engine restarts when
route getactually changes. There are many other instances when unspecified address get added to the system without actually affecting the real default route.** change depends on **
netbirdio/go-netroute#5
Issue ticket number and link
fixes #3352
Checklist