Fix Interface returned from Route on Unix OSes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of dumping the routing table and using IsMoreSpecThan to determine the route of a destination. Use the routing socket to query the route for destination. This approach is similar to using `route get`.
For some reason on FreeBSD, the preferredSrc for route to one of the
local address is 127.0.0.1.
[0] RouteMessage: ver=5, type=4, flags=0x100845, idx=2, id=2124, seq=0, err=<nil>
dst = 192.168.64.7
gateway = [LinkAddr idx=1 name="" addr=]
IFP = [LinkAddr idx=2 name="lo0" addr=]
IFA = 127.0.0.
hurricanehrndz
changed the title
hurricanehrndz
changed the title
6 tasks
hakansa
reviewed
Apr 28, 2025
| }, | ||
| } | ||
|
|
||
| func TestToRoueAddr(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestToRoueAddr(t *testing.T) { | |
| func TestToRouteAddr(t *testing.T) { |
Author
|
I fixed this upstream |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Unix systems specifically Darwin the wrong interface would be returned when multiple candidates for a specific route existed. The Gateway was correct, but the accuracy of the interface returned was not dependable.
https://github.com/libp2p/go-netroute/blob/master/common.go#L57