[client] fix connection state handling #3995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses connection state handling issues in the client UI.
- Removed the conditional check on s.mUp.Disabled() when the status indicates a connected state.
- Simplified the logic to always update the connection state and trigger notifications upon a connected status.
Comments suppressed due to low confidence (1)
client/ui/client_ui.go:575
- The removal of the s.mUp.Disabled() check may lead to the connection state being updated regardless of the UI mediator's state. Please verify that this change is intentional and that it does not introduce any unintended side effects in the UI behavior.
case status.Status == string(internal.StatusConnected):
|
lixmal
approved these changes
Jun 17, 2025
hurricanehrndz
added a commit
to hurricanehrndz/netbird
that referenced
this pull request
Jun 25, 2025
…false_enginerestarts * upstream/main: (228 commits) [management] add breakdown of network map calculation metrics (netbirdio#4020) [client] Don't open cmd.exe during MSI actions (netbirdio#4041) [misc] Specify netbird binary location in Dockerfiles (netbirdio#4024) [management] check and log on new management version (netbirdio#4029) [misc] add additional metrics (netbirdio#4028) [client] close windows when process needs to exit (netbirdio#4027) [client] Refactor showLoginURL to improve error handling and connection status checks (netbirdio#4026) [client] Handle lazy routing peers that are part of HA groups (netbirdio#3943) [management] add transaction for integrated validator groups update and primary account update (netbirdio#4014) [management] export ephemeral peer flag on api (netbirdio#4004) [management] Add backward compatibility for older clients without firewall rules port range support (netbirdio#4003) [client] Fix port range squashing (netbirdio#4007) [client] Add more Android advanced settings (netbirdio#4001) Fix route notification [management] Refactor routes to use store methods (netbirdio#2928) [client] fix connection state handling (netbirdio#3995) [client] Fix logic in updateStatus to correctly handle connection state (netbirdio#3994) [management] Avoid recalculating next peer expiration (netbirdio#3991) [client] Fix DNS Interceptor Build Error (netbirdio#3993) [client] Tighten allowed domains for dns forwarder (netbirdio#3978) ...
volkermauel
pushed a commit
to volkermauel/netbird
that referenced
this pull request
Jun 30, 2025
[client] fix connection state handling (netbirdio#3995)
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
[client] fix connection state handling
Issue ticket number and link
Stack
Checklist