[client] close window when process needs to exit #4027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CommandContext to close advanced settings and re-authentication windows When the main GUI process exits
mlsmaycon
requested review from
Copilot and
hakansa
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug by ensuring that the advanced settings and re-authentication windows are closed appropriately when the main GUI process exits.
- Updated runSelfCommand calls throughout the UI to pass a context parameter.
- Modified runSelfCommand’s signature and its internal command invocation to use exec.CommandContext for proper cancellation handling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/ui/event_handler.go | Updated runSelfCommand calls in handleAdvancedSettingsClick, handleCreateDebugBundleClick, and handleNetworksClick; modified runSelfCommand to accept context and use exec.CommandContext. |
| client/ui/client_ui.go | Updated runSelfCommand call in onSessionExpire to pass the context parameter. |
|
hakansa
approved these changes
Jun 22, 2025
mlsmaycon
changed the title
hurricanehrndz
added a commit
to hurricanehrndz/netbird
that referenced
this pull request
Jun 25, 2025
…false_enginerestarts * upstream/main: (228 commits) [management] add breakdown of network map calculation metrics (netbirdio#4020) [client] Don't open cmd.exe during MSI actions (netbirdio#4041) [misc] Specify netbird binary location in Dockerfiles (netbirdio#4024) [management] check and log on new management version (netbirdio#4029) [misc] add additional metrics (netbirdio#4028) [client] close windows when process needs to exit (netbirdio#4027) [client] Refactor showLoginURL to improve error handling and connection status checks (netbirdio#4026) [client] Handle lazy routing peers that are part of HA groups (netbirdio#3943) [management] add transaction for integrated validator groups update and primary account update (netbirdio#4014) [management] export ephemeral peer flag on api (netbirdio#4004) [management] Add backward compatibility for older clients without firewall rules port range support (netbirdio#4003) [client] Fix port range squashing (netbirdio#4007) [client] Add more Android advanced settings (netbirdio#4001) Fix route notification [management] Refactor routes to use store methods (netbirdio#2928) [client] fix connection state handling (netbirdio#3995) [client] Fix logic in updateStatus to correctly handle connection state (netbirdio#3994) [management] Avoid recalculating next peer expiration (netbirdio#3991) [client] Fix DNS Interceptor Build Error (netbirdio#3993) [client] Tighten allowed domains for dns forwarder (netbirdio#3978) ...
volkermauel
pushed a commit
to volkermauel/netbird
that referenced
this pull request
Jun 30, 2025
This PR fixes a bug by ensuring that the advanced settings and re-authentication windows are closed appropriately when the main GUI process exits. - Updated runSelfCommand calls throughout the UI to pass a context parameter. - Modified runSelfCommand’s signature and its internal command invocation to use exec.CommandContext for proper cancellation handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes a bug by ensuring that the advanced settings and re-authentication windows are closed appropriately when the main GUI process exits.
Issue ticket number and link
Stack
Checklist