Skip to content

Conversation

@wouterlucas
Copy link
Contributor

This PR introduces several improvements and fixes related to the handling of textures in the rendering pipeline.

  • Addressed Texture Reloading Issues: Resolved inconsistencies that occurred when textures transitioned back to a renderable state after being previously marked non-renderable.
  • Preserve Source Data: Adjusted the cleanup process to ensure only the GPU texture is cleared when a texture becomes non-renderable, retaining the source data for potential reuse.
  • Propagate SubTexture Events: Added functionality to forward SubTexture freed events if the parent texture undergoes cleanup, ensuring proper event handling and lifecycle alignment.
  • Introduced comprehensive tests to validate the entire texture lifecycle, ensuring robustness and preventing regressions in future updates. (See screenshot below for test validation details.)

texture-reload-1

@wouterlucas wouterlucas linked an issue Jan 23, 2025 that may be closed by this pull request
@wouterlucas wouterlucas added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 890bb80 Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subtexture textures are not properly cleaned

3 participants