Fixes syntax for checking if pre-commit is installed in isaaclab.sh #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louislelay
requested review from
Dhoeller19,
Mayankm96,
hhansen-bdai,
jsmith-bdai and
kellyguo11
as code owners
Signed-off-by: Kelly Guo <[email protected]>
kellyguo11
reviewed
Dec 5, 2024
Signed-off-by: Kelly Guo <[email protected]>
kellyguo11
reviewed
Dec 5, 2024
Signed-off-by: Kelly Guo <[email protected]>
kellyguo11
reviewed
Dec 5, 2024
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
kellyguo11
approved these changes
Dec 5, 2024
kellyguo11
changed the title
Signed-off-by: Kelly Guo <[email protected]>
SevenFo
pushed a commit
to SevenFo/IsaacLab
that referenced
this pull request
May 19, 2025
…saac-sim#1422) # Description When running `./isaaclab.sh --format` for another pull request, I got a `command not found` error for `pre-commit`. Looking into the script, I found a condition to check if `pre-commit` was installed, but the syntax was off. It was written like this: ```bash if [ ! command -v pre-commit &>/dev/null ]; then ``` But it should be: ```bash if ! command -v pre-commit &>/dev/null; then ``` I fixed it, and the script worked as expected, installing `pre-commit` when I ran it again. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <[email protected]> Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
./isaaclab.sh --formatfor another pull request, I got acommand not founderror forpre-commit. Looking into the script, I found a condition to check ifpre-commitwas installed, but the syntax was off.It was written like this:
But it should be:
I fixed it, and the script worked as expected, installing
pre-commitwhen I ran it again.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there