Skip to content

Fixes syntax for checking if pre-commit is installed in isaaclab.sh #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Fixes syntax for checking if pre-commit is installed in isaaclab.sh #1422

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7ca4672
correct pre-commit installation check
louislelay Nov 14, 2024
818e0fd
update CHANGELOG.rst and extension.toml
louislelay Nov 14, 2024
0e1a512
Merge branch 'main' into fix_precommit_install_check
kellyguo11 Dec 5, 2024
4cba127
Update source/extensions/omni.isaac.lab/docs/CHANGELOG.rst
kellyguo11 Dec 5, 2024
432c19d
Update source/extensions/omni.isaac.lab/docs/CHANGELOG.rst
kellyguo11 Dec 5, 2024
262b6fc
Update source/extensions/omni.isaac.lab/docs/CHANGELOG.rst
kellyguo11 Dec 5, 2024
dd0d60b
Update CHANGELOG.rst
kellyguo11 Dec 5, 2024
0620dea
Update CHANGELOG.rst
kellyguo11 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion isaaclab.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ while [[ $# -gt 0 ]]; do
fi
# run the formatter over the repository
# check if pre-commit is installed
if [ ! command -v pre-commit &>/dev/null ]; then
if ! command -v pre-commit &>/dev/null; then
echo "[INFO] Installing pre-commit..."
pip install pre-commit
fi
Expand Down
2 changes: 1 addition & 1 deletion source/extensions/omni.isaac.lab/config/extension.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]

# Note: Semantic Versioning is used: https://semver.org/
version = "0.27.18"
version = "0.27.19"

# Description
title = "Isaac Lab framework for Robot Learning"
Expand Down
8 changes: 8 additions & 0 deletions source/extensions/omni.isaac.lab/docs/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
Changelog

0.27.15 (2024-11-14)
~~~~~~~~~~~~~~~~~~~~

Fixed
^^^^^

* Fixed the condition in `isaaclab.sh` that checks whether `pre-commit` is installed before attempting installation.
---------

0.27.18 (2024-12-04)
Expand Down