Skip to content

Commit dbb3d4a

Browse files
Fixes syntax for checking if pre-commit is installed in isaaclab.sh (#1422)
# Description When running `./isaaclab.sh --format` for another pull request, I got a `command not found` error for `pre-commit`. Looking into the script, I found a condition to check if `pre-commit` was installed, but the syntax was off. It was written like this: ```bash if [ ! command -v pre-commit &>/dev/null ]; then ``` But it should be: ```bash if ! command -v pre-commit &>/dev/null; then ``` I fixed it, and the script worked as expected, installing `pre-commit` when I ran it again. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <[email protected]> Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
1 parent b0312db commit dbb3d4a

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

isaaclab.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ while [[ $# -gt 0 ]]; do
328328
fi
329329
# run the formatter over the repository
330330
# check if pre-commit is installed
331-
if [ ! command -v pre-commit &>/dev/null ]; then
331+
if ! command -v pre-commit &>/dev/null; then
332332
echo "[INFO] Installing pre-commit..."
333333
pip install pre-commit
334334
fi

source/extensions/omni.isaac.lab/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.27.18"
4+
version = "0.27.19"
55

66
# Description
77
title = "Isaac Lab framework for Robot Learning"

source/extensions/omni.isaac.lab/docs/CHANGELOG.rst

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
Changelog
22
---------
33

4+
0.27.19 (2024-12-05)
5+
~~~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Fixed the condition in ``isaaclab.sh`` that checks whether ``pre-commit`` is installed before attempting installation.
11+
12+
413
0.27.18 (2024-12-04)
514
~~~~~~~~~~~~~~~~~~~~
615

0 commit comments

Comments
 (0)