Marketplace vault #1196
Marketplace vault #1196
Conversation
markspanbroek
force-pushed
the
marketplace-vault
branch
2 times, most recently
from
1e4a0ed to
73ddcce
Compare
On Windows the codex node did not shut down properly after this test finished.
Collateral that needs to be provided is now the same, regardless whether we're repairing or not. The repair reward is added as a bonus, not deducted as a discount.
Hardhat now has the "allowBlocksWithSameTimestamp" property set, which made the test fail. Fixed by explicitly increasing the timestamp in the test.
fixes bugs with slotqueue and repostore, where expiry duration was misinterpreted as expiry timestamp
No longer test against the Marketplace contract directly, but only through the Market abstraction Reason: gas estimates are often incorrect, leading to test failures, and the same test scenarios are already handled by testMarkets
markspanbroek
force-pushed
the
marketplace-vault
branch
from
73ddcce to
307d85a
Compare
markspanbroek
force-pushed
the
fix-api-validation-test
branch
from
0ed671b to
b3994bc
Compare
|
Note to self: nim-codex/codex/sales/states/proving.nim Line 84 in 307d85a This is no longer true because I removed the cancelled callback, we need to exit the proving loop here. |
There was a problem hiding this comment.
Generally LGTM, but honestly this is the type of PR that is really hard to review.
For next time, please really break it up. From my POV, the "hard limit" of a "too big PR" is when the browser has a problem rendering the UI for the PR ... and my Brave was already having problems 😅
| let market = | ||
| OnChainMarket(contract: contract, signer: signer, requestCache: requestCache) | ||
|
|
||
| market.configuration = ?await market.loadConfig() |
There was a problem hiding this comment.
Sorry, I don't understand this construct. I thought that the ? specifies Option for the loaded configuration, but looking at the configuration type I see that you have removed the Option there, so I am not sure what ? does in this context. I assume it is a questionable construct, but I did not really find anything about this there (or I missed it).
2 participants
Uses the latest version of the Marketplace contract that utilize the Vault contract.
This includes the following changes:
And fixes the following bug:
Depends on the fix in #1201
Depends on codex-storage/codex-contracts-eth#220
Depends on codex-storage/codex-contracts-eth#223