chore(marketplace): use hardhat ignition #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2-towns
force-pushed
the
chore/hardhat-ignition
branch
from
1f2caf1 to
bb505db
Compare
2-towns
force-pushed
the
chore/hardhat-ignition
branch
from
0f0e8b1 to
730df2e
Compare
emizzle
requested changes
Jun 5, 2025
tests/integration/hardhatprocess.nim
Outdated
| assert execResult.status == 0 | ||
| except CancelledError as e: | ||
| raise e | ||
| except Exception as e: |
There was a problem hiding this comment.
Suggested change
| except Exception as e: | |
| except CatchableError as e: |
There was a problem hiding this comment.
I used Exception because the compiler was complaining Error: workingDir(node) can raise an unlisted exception: Exception
2-towns
force-pushed
the
chore/hardhat-ignition
branch
from
730df2e to
6805b54
Compare
|
Seems like the tests are failing on the test that you reduced the polling for? Maybe try to revert it? |
emizzle
approved these changes
Jun 9, 2025
Yeah actually I would prefer to have #1268 merged first and rebase this PR on master. |
2-towns
force-pushed
the
chore/hardhat-ignition
branch
from
a8c21bd to
749f27a
Compare
2-towns
force-pushed
the
chore/hardhat-ignition
branch
from
749f27a to
0499e89
Compare
2-towns
force-pushed
the
chore/hardhat-ignition
branch
from
0499e89 to
4966e40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the contracts module in order to use hardhat ignition for deployments and replace the deleted increaseAllowance by allowance / approve functions.