fix(integration): fix api validation test #1201
Conversation
markspanbroek
force-pushed
the
fix-api-validation-test
branch
from
cee95dd to
d6f7fb3
Compare
|
Ugh, I think the reason @2-towns did this was to make the API tests faster. Do we want to revert it? Or maybe we add proper cleanup? Guess this is a bit of a philosophical discussion too: stopping/starting the node on every test will give you perfect isolation but make things significantly slower. OTOH not doing that may provide you some nice wtf moments as the one you just went through @markspanbroek. |
|
There's a lot of integration tests improvements lingering in the parallel integration tests branch, particularly regarding tearing down tests |
Starting and stopping the node on every test is actually quite fast. Especially in comparison to other stuff we do in the integration tests. This change adds a few seconds to the entire suite, at worst. |
On Windows the codex node did not shut down properly after this test finished.
markspanbroek
force-pushed
the
fix-api-validation-test
branch
from
0ed671b to
b3994bc
Compare
markspanbroek
changed the title
* integration: shutdown codex node at end of test On Windows the codex node did not shut down properly after this test finished. * contracts: fix flaky test
Fixes an intermittent problem with other tests because the api validation test kept a codex node alive after it finishes.
Also includes a fix for an unrelated flaky market test, to make the CI pass.