fix(sales): fix marketplace block expiry #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markspanbroek
force-pushed
the
fix-marketplace-block-expiry
branch
from
b8eee11 to
6e55e37
Compare
|
Commit |
Previously we used request.expiry as the block expiry, but the former is a duration in seconds, whereas the latter is a timestamp
markspanbroek
force-pushed
the
fix-marketplace-block-expiry
branch
from
ddea7c4 to
2036e23
Compare
AuHau
approved these changes
Jun 11, 2025
| trace "Retrieving expiry" | ||
| var expiry: SecondsSince1970 | ||
| if state =? requestState and state == RequestState.Started: | ||
| expiry = await market.getRequestEnd(requestId) |
There was a problem hiding this comment.
Upon the filled state, this will get "re-updated" to the same value, but I guess it is not a problem except a bit of wasted CPU cycles.
2-towns
reviewed
Jun 11, 2025
| StorageRequested( | ||
| requestId: request.id, | ||
| ask: request.ask, | ||
| expiry: market.requestExpiry[request.id].uint64, |
There was a problem hiding this comment.
Here the expiry should be the duration no ?
There was a problem hiding this comment.
Yeah, it's really confusing keeping these two uint64 values apart, so that's why in #1196 I created different types for durations and timestamps. But I didn't want to extract all of that into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used request.expiry as the block expiry, but the former is a duration in seconds, whereas the latter is a timestamp.
Extracted the fix from #1196