Skip to content

Conversation

ryansteakley
Copy link
Member

@ryansteakley ryansteakley commented Oct 21, 2021

Release Notes Draft:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the readme w.r.t the breaking changes

@ryansteakley
Copy link
Member Author

Update the readme w.r.t the breaking changes

I believe I have already made the changes in this pr #125 unless you mean calling out in the readme that helm 3.7+ is required?

Copy link
Member

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@surajkota
Copy link
Member

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryansteakley, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ryansteakley,surajkota]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 9b6bf47 into aws-controllers-k8s:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants