regen with codegen v0.15.1 #120
Conversation
ryansteakley
force-pushed
the
update-v0.15.1
branch
2 times, most recently
from
1c53805 to
420a8d5
Compare
and any other files
ryansteakley
force-pushed
the
update-v0.15.1
branch
from
420a8d5 to
07412ae
Compare
| RetainAllVariantProperties: true | ||
| DescribeModelPackage: | ||
| custom_check_required_fields_missing_method: customCheckRequiredFieldsMissingMethod | ||
| primary_identifier_field_name: ARN |
There was a problem hiding this comment.
I don't see this override in the new format. can you elaborate on how it works? because I see that model_package is_identifier has not changed
There was a problem hiding this comment.
Hey Suraj, here it is for your reference aws-controllers-k8s/code-generator#190
The code it generates is the same but the way to enable it has changed. From setting primary_identifier_field_name: ARN to setting it as is_arn_primary_key: true
There was a problem hiding this comment.
Sg, I missed the diff b/w is_primary_key: true to is_arn_primary_key: true
| RetainAllVariantProperties: true | ||
| DescribeModelPackage: | ||
| custom_check_required_fields_missing_method: customCheckRequiredFieldsMissingMethod | ||
| primary_identifier_field_name: ARN |
There was a problem hiding this comment.
Sg, I missed the diff b/w is_primary_key: true to is_arn_primary_key: true
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akartsky, mbaijal, ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Release Notes Draft: - Unit tests for all resources currently included in [pkg/resource](https://github.com/aws-controllers-k8s/sagemaker-controller/tree/main/pkg/resource) - Helm image is updated to be Helm 3.7 compatible #119 -⚠️ **Breaking Change** Helm versions < `3.7` are no longer compatible - Update ACK Runtime from `0.14.0` to `0.15.1` #120 -⚠️ **Breaking Change** `aws-account-id` can no longer be set and has been removed from the charts. - Please refer to https://github.com/aws-controllers-k8s/runtime/releases for a detailed list of changes By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
6 participants
Issue #, if available:
aws-controllers-k8s/community#1014
Description of changes:
Update to codegen v0.15.1 and use runtime v0.15.1 in the runtime
is_primary_arninstead ofprimary_identifier_fieldResourceGKwas renamed toGroupKindso changed this field wherever we used it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.