Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ The following sections will guide you to install SageMaker and Application Autos
This guide assumes that you’ve the following prerequisites:
- Installed the following tools on the client machine used to access your Kubernetes cluster:
- [kubectl](https://docs.aws.amazon.com/eks/latest/userguide/install-kubectl.html) - A command line tool for working with Kubernetes clusters.
- [helm](https://helm.sh/docs/intro/install/) - A tool for installing and managing Kubernetes applications
- [helm 3.7+](https://helm.sh/docs/intro/install/) - A tool for installing and managing Kubernetes applications
- [AWS CLI](https://docs.aws.amazon.com/cli/latest/userguide/install-cliv1.html) - A command line tool for interacting with AWS services.
- [eksctl](https://docs.aws.amazon.com/eks/latest/userguide/eksctl.html) - A command line tool for working with EKS clusters that automates many individual tasks.
- [yq](https://mikefarah.gitbook.io/yq) - command-line YAML processor.
Expand Down Expand Up @@ -160,11 +160,11 @@ Take note of IAM_ROLE_ARN_FOR_IRSA printed in the previous step; you will pass t
#### 3.1 Install SageMaker Controller

##### 3.1.1 Download helm chart

- Helm version 3.7 or greater is required. Helm versions < 3.7 are incompatible.
```sh
export HELM_EXPERIMENTAL_OCI=1
export SERVICE=sagemaker
export RELEASE_VERSION=v0.1.0
export RELEASE_VERSION=v0.2.0
export CHART_EXPORT_PATH=/tmp/chart
export CHART_REF=$SERVICE-chart
export CHART_REPO=public.ecr.aws/aws-controllers-k8s/$CHART_REF
Expand Down Expand Up @@ -225,7 +225,7 @@ Jump to Section 4.0 if you only wish to install SageMaker controller
```sh
export HELM_EXPERIMENTAL_OCI=1
export SERVICE=applicationautoscaling
export RELEASE_VERSION=v0.1.1
export RELEASE_VERSION=v0.2.0
export CHART_EXPORT_PATH=/tmp/chart
export CHART_REF=$SERVICE-chart
export CHART_REPO=public.ecr.aws/aws-controllers-k8s/$CHART_REF
Expand Down
2 changes: 1 addition & 1 deletion apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ack_generate_info:
build_date: "2021-10-08T20:19:54Z"
build_date: "2021-10-21T19:55:26Z"
build_hash: 1eaee0ea592ad5752cb9d403e2c13e9a7bdb8d33
go_version: go1.17.1
version: v0.15.1
Expand Down
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: sagemaker-chart
description: A Helm chart for the ACK service controller for Amazon SageMaker (SageMaker)
version: v0.1.0
appVersion: v0.1.0
version: v0.2.0
appVersion: v0.2.0
home: https://github.com/aws-controllers-k8s/sagemaker-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/sagemaker-controller
tag: v0.1.0
tag: v0.2.0
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down
2 changes: 1 addition & 1 deletion pkg/resource/notebook_instance/hooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ var (
svcsdk.NotebookInstanceStatusStopping,
}

resourceName = GroupKind.Kind
resourceName = GroupKind.Kind
requeueWaitWhileDeleting = ackrequeue.NeededAfter(
errors.New(resourceName+" is deleting."),
ackrequeue.DefaultRequeueAfterDuration,
Expand Down