Skip to content

Conversation

ryansteakley
Copy link
Member

Description of changes:

  • Update the install link to helm 3.7 and update README to reflect installing charts using helm 3.7

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vijtrip2
Copy link
Contributor

/test sagemaker-release-test

@vijtrip2
Copy link
Contributor

release-test is failing here because ack-runtime version is not yet updated in go.mod
Once the runtime version upgrade PR is merged, this should start passing.

@mbaijal
Copy link
Contributor

mbaijal commented Oct 15, 2021

/test sagemaker-release-test

README.md Outdated
export HELM_EXPERIMENTAL_OCI=1
export SERVICE=sagemaker
export RELEASE_VERSION=v0.1.0
export RELEASE_VERSION=v0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated as a part of the release artifacts PR correct ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I believe so,will revert it

@mbaijal
Copy link
Contributor

mbaijal commented Oct 15, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaijal, ryansteakley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mbaijal,ryansteakley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 5f97f5a into aws-controllers-k8s:main Oct 15, 2021
ack-bot pushed a commit that referenced this pull request Oct 22, 2021
Release Notes Draft:
- Unit tests for all resources currently included in [pkg/resource](https://github.com/aws-controllers-k8s/sagemaker-controller/tree/main/pkg/resource)
- Helm image is updated to be Helm 3.7 compatible #119
  -  ⚠️ **Breaking Change** Helm versions < `3.7` are no longer compatible
- Update ACK Runtime from `0.14.0` to `0.15.1` #120
  - ⚠️ **Breaking Change** `aws-account-id` can no longer be set and has been removed from the charts.
  - Please refer to https://github.com/aws-controllers-k8s/runtime/releases for a detailed list of changes 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants