-
Notifications
You must be signed in to change notification settings - Fork 41
Update canary helm install to helm 3.7 and update README #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update canary helm install to helm 3.7 and update README #119
Conversation
/test sagemaker-release-test |
release-test is failing here because ack-runtime version is not yet updated in go.mod |
/test sagemaker-release-test |
README.md
Outdated
export HELM_EXPERIMENTAL_OCI=1 | ||
export SERVICE=sagemaker | ||
export RELEASE_VERSION=v0.1.0 | ||
export RELEASE_VERSION=v0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated as a part of the release artifacts PR correct ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I believe so,will revert it
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaijal, ryansteakley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Release Notes Draft: - Unit tests for all resources currently included in [pkg/resource](https://github.com/aws-controllers-k8s/sagemaker-controller/tree/main/pkg/resource) - Helm image is updated to be Helm 3.7 compatible #119 -⚠️ **Breaking Change** Helm versions < `3.7` are no longer compatible - Update ACK Runtime from `0.14.0` to `0.15.1` #120 -⚠️ **Breaking Change** `aws-account-id` can no longer be set and has been removed from the charts. - Please refer to https://github.com/aws-controllers-k8s/runtime/releases for a detailed list of changes By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.