Update canary helm install to helm 3.7 and update README #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test sagemaker-release-test |
|
release-test is failing here because ack-runtime version is not yet updated in go.mod |
|
/test sagemaker-release-test |
mbaijal
reviewed
Oct 15, 2021
README.md
Outdated
| export HELM_EXPERIMENTAL_OCI=1 | ||
| export SERVICE=sagemaker | ||
| export RELEASE_VERSION=v0.1.0 | ||
| export RELEASE_VERSION=v0.2.0 |
There was a problem hiding this comment.
This should be updated as a part of the release artifacts PR correct ?
There was a problem hiding this comment.
Yes I believe so,will revert it
mbaijal
approved these changes
Oct 15, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaijal, ryansteakley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
that referenced
this pull request
Oct 22, 2021
Release Notes Draft: - Unit tests for all resources currently included in [pkg/resource](https://github.com/aws-controllers-k8s/sagemaker-controller/tree/main/pkg/resource) - Helm image is updated to be Helm 3.7 compatible #119 -⚠️ **Breaking Change** Helm versions < `3.7` are no longer compatible - Update ACK Runtime from `0.14.0` to `0.15.1` #120 -⚠️ **Breaking Change** `aws-account-id` can no longer be set and has been removed from the charts. - Please refer to https://github.com/aws-controllers-k8s/runtime/releases for a detailed list of changes By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.