Skip to content

Errors while generating sagemaker-controller for ACK runtime v0.15.1 #1014

@ack-bot

Description

@ack-bot

Errors while generating sagemaker-controller for ACK runtime v0.15.1

stdout for make build-controller:

building ack-generate ... ok.
==== building sagemaker-controller ====
Copying common custom resource definitions into sagemaker
Building Kubernetes API objects for sagemaker
Generating deepcopy code for sagemaker
Generating custom resource definitions for sagemaker
Building service controller for sagemaker

stderr for make build-controller:

Error: template: /home/prow/go/src/github.com/aws-controllers-k8s/code-generator/templates/pkg/resource/resource.go.tpl:82:4: executing "/home/prow/go/src/github.com/aws-controllers-k8s/code-generator/templates/pkg/resource/resource.go.tpl" at <GoCodeSetResourceIdentifiers .CRD "identifier" "r.ko" 1>: error calling GoCodeSetResourceIdentifiers: Could not find primary identifier for ModelQualityJobDefinition. Set `is_primary_key` for the primary field in the ModelQualityJobDefinition resource.
make: *** [Makefile:34: build-controller] Error 1

Steps for closing this issue:

  1. Update go.mod file to update aws-controllers-k8s/runtime to v0.15.1
  2. Successfully generate the service controller locally using latest release of
    aws-controllers-k8s/code-generator
  3. Run go mod tidy for sagemaker-controller
  4. Run make test for sagemaker-controller
  5. Run make kind-test from aws-controllers-k8s/test-infra repository for
    sagemaker-controller
  6. When kind test is successful, Create new pull request for sagemaker-controller
  7. Mention this issue number in the pull request
  8. When the above PR is merged, close this issue

For more guidance, create an issue
or reach out on Slack.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions