This repository was archived by the owner on Sep 5, 2024. It is now read-only.
update fork from origin #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Purpose Remove the forced 70% opacity overlay to allow more flexibility - for instance if you want 90% instead. ## Use When declaring overlay background, you could feed it `rgba(255, 255, 255, 0.9)` to achieve a white overlay that is only slightly transparent.
Adds UNSAFE_ prefix for deprecated lifecycle hooks. (For more information about this codemod, see [React RFC #6](reactjs/rfcs#6))
This PR makes Gesture Handler compatible with AndroidX, by using Nullable annotation and Pools from AndroidX. But also removes **buildToolsVersion** as it's no longer required by Android Gradle Plugin since version 3.1.0, see https://developer.android.com/studio/releases/gradle-plugin#3-1-0, and bumped compileSdkVersion, targetSdkVersion to 28. Upgraded **Example** app, and had to bump Android Gradle Version, thus Gradle wrapper version. Also had to run **jetify** because some dependencies are not AndroidX ready.
`Component.displayName` can be undefined for release builds which means a bunch of components will fight for the undefined key. In my app it results in the `Switch` component rendering nothing (or probably just another component like `ScrollView`). I also added a null check since some components are being removed from RN core like ToolbarAndroid so it makes `memoizeWrap` safe in those cases.
…e can use this view inside an xml layout file (#755)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for RN0.61
please view the PR and merge it.