Skip to content

Conversation

@rszalski
Copy link
Contributor

This fixes the following TS error:

Type '{ children: Element; style: any; underlayColor: string; rippleColor: string; onPress: () => void; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<RectButton> & Readonly<{ children?: ReactNode; }> & Readonly<RectButtonProperties>'.
  Property 'rippleColor' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<RectButton> & Readonly<{ children?: ReactNode; }> & Readonly<RectButtonProperties>'.ts(2322)

@Andarius
Copy link
Contributor

@rszalski
Copy link
Contributor Author

rszalski commented Jul 22, 2019

@Andarius You are correct, thank you. I somehow looked at the wrong button in the docs 😅

I'll re-test and fix this.

Edit: Fixed

@rszalski rszalski force-pushed the fix/add-ripplecolor-to-rectbutton-types branch from 94096eb to afcedb6 Compare July 22, 2019 19:51
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@kmagiera kmagiera merged commit cf2f393 into software-mansion:master Jul 29, 2019
@rszalski rszalski deleted the fix/add-ripplecolor-to-rectbutton-types branch September 2, 2019 17:20
jordmccord pushed a commit to jordmccord/react-native-gesture-handler that referenced this pull request Sep 18, 2019
janicduplessis pushed a commit to janicduplessis/react-native-gesture-handler that referenced this pull request Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants