use AndroidX #734
Merged
use AndroidX #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwilliam
approved these changes
Aug 21, 2019
|
Android CI is green 👍 |
|
@kmagiera CI is green, and good to be merged 😎 |
|
Awesome job @dulmandakh – thanks so much for your help! |
janicduplessis
pushed a commit
to janicduplessis/react-native-gesture-handler
that referenced
this pull request
Feb 16, 2020
This PR makes Gesture Handler compatible with AndroidX, by using Nullable annotation and Pools from AndroidX. But also removes **buildToolsVersion** as it's no longer required by Android Gradle Plugin since version 3.1.0, see https://developer.android.com/studio/releases/gradle-plugin#3-1-0, and bumped compileSdkVersion, targetSdkVersion to 28. Upgraded **Example** app, and had to bump Android Gradle Version, thus Gradle wrapper version. Also had to run **jetify** because some dependencies are not AndroidX ready.
|
Hi, I'm wondering why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Gesture Handler compatible with AndroidX, by using Nullable annotation and Pools from AndroidX. But also removes buildToolsVersion as it's no longer required by Android Gradle Plugin since version 3.1.0, see https://developer.android.com/studio/releases/gradle-plugin#3-1-0, and bumped compileSdkVersion, targetSdkVersion to 28.
Upgraded Example app, and had to bump Android Gradle Version, thus Gradle wrapper version. Also had to run jetify because some dependencies are not AndroidX ready.