-
-
Notifications
You must be signed in to change notification settings - Fork 44
Fix fail to start on assignemnt of nonexistent device #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It was reproduced and tested to be working. |
Make sure global config tolerates weird phantom devices well. fixes QubesOS/qubes-issues#10080
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 93.00% 92.97% -0.03%
==========================================
Files 64 64
Lines 13217 13275 +58
==========================================
+ Hits 12292 12343 +51
- Misses 925 932 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025100312-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 83 fixed
Unstable testsPerformance TestsPerformance degradation:15 performance degradations
Remaining performance tests:165 tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProtocolError is probably not the best exception that should happen here, but well, the backend raises ProtocolError right now, so the frontend part is correct as is
This is proposed fix for QubesOS/qubes-issues#10080, but I failed to reproduce the bug (including in tests).
fixes QubesOS/qubes-issues#10080