Prevent backing up dom0 it itself (in home dir) #731

alimirjamali · 2025-09-11T18:25:34Z

In case there is no an existing backup profile, select sys-usb as the default target. In case there is no `sys-usb` (e.g. on live Qubes scenario), still revert to dom0 If dom0 is included in backup and target is user home dir in dom0, another patch to core shows an error message. Cover it as well resolves: QubesOS/qubes-issues#10127 depends: QubesOS/qubes-core-admin#731

codecov · 2025-09-11T19:16:46Z

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.30%. Comparing base (02c245e) to head (301e66f).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
qubes/backup.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   70.41%   70.30%   -0.11%     
==========================================
  Files          61       61              
  Lines       13679    13649      -30     
==========================================
- Hits         9632     9596      -36     
- Misses       4047     4053       +6

Flag	Coverage Δ
unittests	`70.30% <33.33%> (-0.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

In case there is no an existing backup profile, select sys-usb as the default target. In case there is no `sys-usb` (e.g. on live Qubes scenario), still revert to dom0 If dom0 is included in backup and target is user home dir in dom0, another patch to core shows an error message. Cover it as well resolves: QubesOS/qubes-issues#10127 depends: QubesOS/qubes-core-admin#731

qubesos-bot · 2025-09-15T11:06:18Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025100312-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update

system_tests_network
- VmNetworking_debian-13-xfce: test_001_simple_networking_paused_change_purge_old (failure)
  AssertionError: 2 != 0 : Ping by IP on netvm=something -> netvm=som...
system_tests_network_ipv6
- VmIPv6Networking_debian-13-xfce: test_520_ipv6_simple_proxyvm_nm (failure)
  AssertionError: 1 != 0 : nm-applet window not found
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/qDqV_-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_NonAudio_whonix-gateway-17-pool: test_401_long_window_title_utf8 (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError

Failed tests

8 failures

system_tests_network
- VmNetworking_debian-13-xfce: test_001_simple_networking_paused_change_purge_old (failure)
  AssertionError: 2 != 0 : Ping by IP on netvm=something -> netvm=som...
system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
system_tests_network_ipv6
- VmIPv6Networking_debian-13-xfce: test_520_ipv6_simple_proxyvm_nm (failure)
  AssertionError: 1 != 0 : nm-applet window not found
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/qDqV_-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_NonAudio_whonix-gateway-17-pool: test_401_long_window_title_utf8 (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/149225#dependencies

83 fixed

system_tests_dispvm
- system_tests: Fail (unknown)
  Tests qubes.tests.integ.dispvm failed (exit code 1), details report...
- system_tests: Failed (test died)
  # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...
- TC_20_DispVM_debian-13-xfce: test_012_preload_low_mem (failure)
  ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0
- TC_20_DispVM_debian-13-xfce: test_013_preload_gui (error)
  raise KeyError(key)... KeyError: 'disp3723'
- TC_20_DispVM_debian-13-xfce: test_014_preload_nogui (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
- TC_20_DispVM_debian-13-xfce: test_015_preload_race_more (error + cleanup)
  raise KeyError(key)... KeyError: 'disp1187'
- TC_20_DispVM_debian-13-xfce: test_016_preload_race_less (failure + cleanup)
  ^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- TC_20_DispVM_debian-13-xfce: test_017_preload_autostart (error)
  raise KeyError(key)... KeyError: 'disp7317'
- TC_20_DispVM_debian-13-xfce: test_018_preload_global (error)
  raise KeyError(key)... KeyError: 'disp8572'
- TC_20_DispVM_debian-13-xfce: test_019_preload_refresh (error)
  raise KeyError(key)... KeyError: 'disp6425'
- TC_20_DispVM_fedora-42-xfce: test_012_preload_low_mem (failure)
  ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0
- TC_20_DispVM_whonix-workstation-17: test_012_preload_low_mem (failure)
  ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 1 != 0
system_tests_audio
- system_tests: Fail (unknown)
  Tests qubes.tests.integ.audio failed (exit code 1), details reporte...
- system_tests: Failed (test died)
  # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_224_audio_rec_muted_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_audio@hw1
- system_tests: Fail (unknown)
  Tests qubes.tests.integ.audio failed (exit code 1), details reporte...
- system_tests: Failed (test died)
  # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_224_audio_rec_muted_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...
system_tests_guivm_gpu_gui_interactive@hw13
- guivm_startup: wait_serial (wait serial expected)
  # wait_serial expected: qr/lEcbc-\d+-/...
- guivm_startup: Failed (test died + timed out)
  # Test died: command '! qvm-check sys-whonix || time qvm-start sys-...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_NonAudio_whonix-gateway-17-pool: test_012_qubes_desktop_run (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_dispvm_perf@hw7
- system_tests: Fail (unknown)
  Tests qubes.tests.integ.dispvm_perf failed (exit code 1), details r...
- system_tests: wait_serial (wait serial expected)
  # wait_serial expected: qr/D2qNh-\d+-/...
- system_tests: Failed (test died + timed out)
  # Test died: command 'sudo python3 split_logs.py --junit-xml=nose2-...
- TC_00_DispVMPerf_debian-13-xfce: test_000_dispvm (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_002_dispvm_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_006_dispvm_from_dom0 (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_008_dispvm_from_dom0_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_020_dispvm_preload (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_021_dispvm_preload_gui (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_022_dispvm_preload_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_023_dispvm_preload_gui_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_026_dispvm_from_dom0_preload (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_027_dispvm_from_dom0_preload_gui (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_028_dispvm_from_dom0_preload_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_029_dispvm_from_dom0_preload_gui_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_400_dispvm_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_402_dispvm_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_404_dispvm_preload_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_404_dispvm_preload_less_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_404_dispvm_preload_more_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_405_dispvm_preload_gui_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_406_dispvm_preload_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_407_dispvm_preload_gui_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_900_vm (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_902_vm_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_904_vm_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_debian-13-xfce: test_906_vm_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_020_dispvm_preload (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_021_dispvm_preload_gui (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_022_dispvm_preload_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_023_dispvm_preload_gui_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_026_dispvm_from_dom0_preload (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_027_dispvm_from_dom0_preload_gui (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_028_dispvm_from_dom0_preload_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_029_dispvm_from_dom0_preload_gui_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_404_dispvm_preload_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_404_dispvm_preload_less_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_404_dispvm_preload_more_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_405_dispvm_preload_gui_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_406_dispvm_preload_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_fedora-42-xfce: test_407_dispvm_preload_gui_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_020_dispvm_preload (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_021_dispvm_preload_gui (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_022_dispvm_preload_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_023_dispvm_preload_gui_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_026_dispvm_from_dom0_preload (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_027_dispvm_from_dom0_preload_gui (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_028_dispvm_from_dom0_preload_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_029_dispvm_from_dom0_preload_gui_concurrent (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_404_dispvm_preload_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_404_dispvm_preload_less_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_404_dispvm_preload_more_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_405_dispvm_preload_gui_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_406_dispvm_preload_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...
- TC_00_DispVMPerf_whonix-workstation-17: test_407_dispvm_preload_gui_concurrent_api (failure)
  AssertionError: '/usr/lib/qubes/tests/dispvm_perf.py --dvm=test-ins...

Unstable tests

Performance Tests

Performance degradation:

15 performance degradations

dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 235635.00 🔻 ( previous job: 265260.00, degradation: 88.83%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 104385.00 🔻 ( previous job: 431512.00, degradation: 24.19%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 58590.00 🔻 ( previous job: 196254.00, degradation: 29.85%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2091.00 🔻 ( previous job: 2446.00, degradation: 85.49%)
fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 32808.00 🔻 ( previous job: 47575.00, degradation: 68.96%)
fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1135.00 🔻 ( previous job: 3020.00, degradation: 37.58%)
fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8074.00 🔻 ( previous job: 9042.00, degradation: 89.29%)
fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 866.00 🔻 ( previous job: 1368.00, degradation: 63.30%)
fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 345153.00 🔻 ( previous job: 387500.00, degradation: 89.07%)
fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 41694.00 🔻 ( previous job: 79539.00, degradation: 52.42%)
fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2397.00 🔻 ( previous job: 3765.00, degradation: 63.67%)
fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 366.00 🔻 ( previous job: 1251.00, degradation: 29.26%)
fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 58939.00 🔻 ( previous job: 157382.00, degradation: 37.45%)
fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 1962.00 🔻 ( previous job: 4098.00, degradation: 47.88%)
fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 866.00 🔻 ( previous job: 2384.00, degradation: 36.33%)

Remaining performance tests:

165 tests

dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 486804.00 🔻 ( previous job: 497426.00, degradation: 97.86%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 45159.00 🟢 ( previous job: 23940.00, improvement: 188.63%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 12059.00 🟢 ( previous job: 5874.00, improvement: 205.29%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 349.00 🟢 ( previous job: 29.00, improvement: 1203.45%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 474039.00 🟢 ( previous job: 292489.00, improvement: 162.07%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 109166.00 🔻 ( previous job: 110817.00, degradation: 98.51%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 424524.00 🟢 ( previous job: 137802.00, improvement: 308.07%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 136887.00 🟢 ( previous job: 121719.00, improvement: 112.46%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 105880.00 🟢 ( previous job: 103932.00, improvement: 101.87%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 10231.00 🟢 ( previous job: 6356.00, improvement: 160.97%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8205.00 🟢 ( previous job: 7695.00, improvement: 106.63%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4327.00 🟢 ( previous job: 3925.00, improvement: 110.24%)
fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 359224.00 🔻 ( previous job: 366891.00, degradation: 97.91%)
fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 142300.00 🟢 ( previous job: 140215.00, improvement: 101.49%)
fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 280592.00 🔻 ( previous job: 299764.00, degradation: 93.60%)
fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 83176.00 🔻 ( previous job: 86001.00, degradation: 96.72%)
fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 143708.00 🟢 ( previous job: 136640.00, improvement: 105.17%)
fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 363206.00 🟢 ( previous job: 325139.00, improvement: 111.71%)
fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 90555.00 🟢 ( previous job: 87396.00, improvement: 103.61%)
fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8614.00 🔻 ( previous job: 8992.00, degradation: 95.80%)
fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 378137.00 🔻 ( previous job: 383531.00, degradation: 98.59%)
fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 329844.00 🟢 ( previous job: 293225.00, improvement: 112.49%)
fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 61844.00 🔻 ( previous job: 64217.00, degradation: 96.30%)
fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 80075.00 🔻 ( previous job: 87141.00, degradation: 91.89%)
fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8315.00 🔻 ( previous job: 8804.00, degradation: 94.45%)
debian-13-xfce_exec: 7.53 🟢 ( previous job: 8.36, improvement: 90.11%)
debian-13-xfce_exec-root: 26.89 🟢 ( previous job: 27.36, improvement: 98.26%)
debian-13-xfce_socket: 8.37 🟢 ( previous job: 8.57, improvement: 97.68%)
debian-13-xfce_socket-root: 8.38 🔻 ( previous job: 8.26, degradation: 101.45%)
debian-13-xfce_exec-data-simplex: 67.04 🟢 ( previous job: 72.43, improvement: 92.57%)
debian-13-xfce_exec-data-duplex: 69.87 🟢 ( previous job: 76.65, improvement: 91.16%)
debian-13-xfce_exec-data-duplex-root: 79.93 🟢 ( previous job: 91.79, improvement: 87.08%)
debian-13-xfce_socket-data-duplex: 130.81 🟢 ( previous job: 133.45, improvement: 98.02%)
fedora-42-xfce_exec: 9.24 🔻 ( previous job: 9.06, degradation: 102.01%)
fedora-42-xfce_exec-root: 60.53 🔻 ( previous job: 58.19, degradation: 104.02%)
fedora-42-xfce_socket: 7.92 🟢 ( previous job: 8.48, improvement: 93.43%)
fedora-42-xfce_socket-root: 8.22 🔻 ( previous job: 8.18, degradation: 100.47%)
fedora-42-xfce_exec-data-simplex: 61.84 🟢 ( previous job: 78.48, improvement: 78.79%)
fedora-42-xfce_exec-data-duplex: 71.11 🔻 ( previous job: 67.92, degradation: 104.71%)
fedora-42-xfce_exec-data-duplex-root: 101.10 🔻 ( previous job: 96.36, degradation: 104.91%)
fedora-42-xfce_socket-data-duplex: 137.98 🟢 ( previous job: 142.58, improvement: 96.77%)
whonix-gateway-17_exec: 7.03 🟢 ( previous job: 8.12, improvement: 86.66%)
whonix-gateway-17_exec-root: 39.57 🟢 ( previous job: 41.05, improvement: 96.39%)
whonix-gateway-17_socket: 7.88 🟢 ( previous job: 8.52, improvement: 92.42%)
whonix-gateway-17_socket-root: 6.85 🟢 ( previous job: 8.12, improvement: 84.44%)
whonix-gateway-17_exec-data-simplex: 68.69 🟢 ( previous job: 83.60, improvement: 82.17%)
whonix-gateway-17_exec-data-duplex: 73.33 🔻 ( previous job: 68.38, degradation: 107.23%)
whonix-gateway-17_exec-data-duplex-root: 85.42 🟢 ( previous job: 99.37, improvement: 85.96%)
whonix-gateway-17_socket-data-duplex: 154.89 🟢 ( previous job: 167.12, improvement: 92.68%)
whonix-workstation-17_exec: 8.18 🔻 ( previous job: 7.57, degradation: 108.10%)
whonix-workstation-17_exec-root: 53.89 🟢 ( previous job: 56.76, improvement: 94.94%)
whonix-workstation-17_socket: 8.71 🔻 ( previous job: 8.59, degradation: 101.45%)
whonix-workstation-17_socket-root: 8.53 🟢 ( previous job: 8.89, improvement: 95.94%)
whonix-workstation-17_exec-data-simplex: 66.55 🟢 ( previous job: 66.80, improvement: 99.62%)
whonix-workstation-17_exec-data-duplex: 74.38 🟢 ( previous job: 74.50, improvement: 99.84%)
whonix-workstation-17_exec-data-duplex-root: 90.51 🟢 ( previous job: 102.34, improvement: 88.44%)
whonix-workstation-17_socket-data-duplex: 144.96 🟢 ( previous job: 147.97, improvement: 97.96%)
debian-13-xfce_vm-dispvm (mean:6.784): 81.41
debian-13-xfce_vm-dispvm-gui (mean:7.485): 89.82
debian-13-xfce_vm-dispvm-concurrent (mean:3.18): 38.16
debian-13-xfce_vm-dispvm-gui-concurrent (mean:3.958): 47.49
debian-13-xfce_dom0-dispvm (mean:7.068): 84.82
debian-13-xfce_dom0-dispvm-gui (mean:8.393): 100.71
debian-13-xfce_dom0-dispvm-concurrent (mean:3.295): 39.54
debian-13-xfce_dom0-dispvm-gui-concurrent (mean:4.278): 51.33
debian-13-xfce_vm-dispvm-preload (mean:2.823): 33.87
debian-13-xfce_vm-dispvm-preload-gui (mean:3.971): 47.66
debian-13-xfce_vm-dispvm-preload-concurrent (mean:2.637): 31.64
debian-13-xfce_vm-dispvm-preload-gui-concurrent (mean:3.542): 42.51
debian-13-xfce_dom0-dispvm-preload (mean:3.596): 43.15
debian-13-xfce_dom0-dispvm-preload-gui (mean:4.599): 55.19
debian-13-xfce_dom0-dispvm-preload-concurrent (mean:3.055): 36.66
debian-13-xfce_dom0-dispvm-preload-gui-concurrent (mean:3.854): 46.25
debian-13-xfce_dom0-dispvm-api (mean:7.006): 84.07
debian-13-xfce_dom0-dispvm-gui-api (mean:8.252): 99.02
debian-13-xfce_dom0-dispvm-concurrent-api (mean:3.344): 40.12
debian-13-xfce_dom0-dispvm-gui-concurrent-api (mean:3.98): 47.76
debian-13-xfce_dom0-dispvm-preload-less-less-api (mean:3.7): 44.40
debian-13-xfce_dom0-dispvm-preload-less-api (mean:3.46): 41.52
debian-13-xfce_dom0-dispvm-preload-api (mean:3.437): 41.25
debian-13-xfce_dom0-dispvm-preload-more-api (mean:3.281): 39.37
debian-13-xfce_dom0-dispvm-preload-more-more-api (mean:3.404): 40.84
debian-13-xfce_dom0-dispvm-preload-gui-api (mean:4.524): 54.28
debian-13-xfce_dom0-dispvm-preload-concurrent-api (mean:2.965): 35.58
debian-13-xfce_dom0-dispvm-preload-gui-concurrent-api (mean:3.867): 46.41
debian-13-xfce_vm-vm (mean:0.035): 0.42
debian-13-xfce_vm-vm-gui (mean:0.032): 0.38
debian-13-xfce_vm-vm-concurrent (mean:0.015): 0.18
debian-13-xfce_vm-vm-gui-concurrent (mean:0.026): 0.31
debian-13-xfce_dom0-vm-api (mean:0.036): 0.43
debian-13-xfce_dom0-vm-gui-api (mean:0.037): 0.45
debian-13-xfce_dom0-vm-concurrent-api (mean:0.035): 0.42
debian-13-xfce_dom0-vm-gui-concurrent-api (mean:0.026): 0.31
fedora-42-xfce_vm-dispvm (mean:7.201): 86.42
fedora-42-xfce_vm-dispvm-gui (mean:8.233): 98.80
fedora-42-xfce_vm-dispvm-concurrent (mean:3.836): 46.03
fedora-42-xfce_vm-dispvm-gui-concurrent (mean:4.215): 50.58
fedora-42-xfce_dom0-dispvm (mean:7.338): 88.06
fedora-42-xfce_dom0-dispvm-gui (mean:8.586): 103.03
fedora-42-xfce_dom0-dispvm-concurrent (mean:3.732): 44.79
fedora-42-xfce_dom0-dispvm-gui-concurrent (mean:4.532): 54.38
fedora-42-xfce_vm-dispvm-preload (mean:3.022): 36.26
fedora-42-xfce_vm-dispvm-preload-gui (mean:4.274): 51.29
fedora-42-xfce_vm-dispvm-preload-concurrent (mean:2.884): 34.61
fedora-42-xfce_vm-dispvm-preload-gui-concurrent (mean:3.494): 41.93
fedora-42-xfce_dom0-dispvm-preload (mean:4.053): 48.64
fedora-42-xfce_dom0-dispvm-preload-gui (mean:5.018): 60.22
fedora-42-xfce_dom0-dispvm-preload-concurrent (mean:3.51): 42.12
fedora-42-xfce_dom0-dispvm-preload-gui-concurrent (mean:4.064): 48.77
fedora-42-xfce_dom0-dispvm-api (mean:7.547): 90.57
fedora-42-xfce_dom0-dispvm-gui-api (mean:8.852): 106.22
fedora-42-xfce_dom0-dispvm-concurrent-api (mean:3.824): 45.89
fedora-42-xfce_dom0-dispvm-gui-concurrent-api (mean:4.465): 53.59
fedora-42-xfce_dom0-dispvm-preload-less-less-api (mean:4.292): 51.50
fedora-42-xfce_dom0-dispvm-preload-less-api (mean:4.515): 54.19
fedora-42-xfce_dom0-dispvm-preload-api (mean:3.791): 45.50
fedora-42-xfce_dom0-dispvm-preload-more-api (mean:3.784): 45.41
fedora-42-xfce_dom0-dispvm-preload-more-more-api (mean:4.014): 48.17
fedora-42-xfce_dom0-dispvm-preload-gui-api (mean:5.032): 60.38
fedora-42-xfce_dom0-dispvm-preload-concurrent-api (mean:3.416): 40.99
fedora-42-xfce_dom0-dispvm-preload-gui-concurrent-api (mean:4.144): 49.72
fedora-42-xfce_vm-vm (mean:0.032): 0.38
fedora-42-xfce_vm-vm-gui (mean:0.036): 0.43
fedora-42-xfce_vm-vm-concurrent (mean:0.023): 0.27
fedora-42-xfce_vm-vm-gui-concurrent (mean:0.032): 0.38
fedora-42-xfce_dom0-vm-api (mean:0.039): 0.47
fedora-42-xfce_dom0-vm-gui-api (mean:0.043): 0.52
fedora-42-xfce_dom0-vm-concurrent-api (mean:0.032): 0.38
fedora-42-xfce_dom0-vm-gui-concurrent-api (mean:0.038): 0.46
whonix-workstation-17_vm-dispvm (mean:7.852): 94.23
whonix-workstation-17_vm-dispvm-gui (mean:8.54): 102.47
whonix-workstation-17_vm-dispvm-concurrent (mean:3.874): 46.49
whonix-workstation-17_vm-dispvm-gui-concurrent (mean:4.725): 56.70
whonix-workstation-17_dom0-dispvm (mean:8.415): 100.98
whonix-workstation-17_dom0-dispvm-gui (mean:9.208): 110.50
whonix-workstation-17_dom0-dispvm-concurrent (mean:4.314): 51.77
whonix-workstation-17_dom0-dispvm-gui-concurrent (mean:4.604): 55.25
whonix-workstation-17_vm-dispvm-preload (mean:3.435): 41.22
whonix-workstation-17_vm-dispvm-preload-gui (mean:4.678): 56.13
whonix-workstation-17_vm-dispvm-preload-concurrent (mean:3.422): 41.06
whonix-workstation-17_vm-dispvm-preload-gui-concurrent (mean:4.066): 48.79
whonix-workstation-17_dom0-dispvm-preload (mean:4.235): 50.82
whonix-workstation-17_dom0-dispvm-preload-gui (mean:5.308): 63.70
whonix-workstation-17_dom0-dispvm-preload-concurrent (mean:3.845): 46.14
whonix-workstation-17_dom0-dispvm-preload-gui-concurrent (mean:4.42): 53.05
whonix-workstation-17_dom0-dispvm-api (mean:8.489): 101.86
whonix-workstation-17_dom0-dispvm-gui-api (mean:9.407): 112.89
whonix-workstation-17_dom0-dispvm-concurrent-api (mean:4.147): 49.77
whonix-workstation-17_dom0-dispvm-gui-concurrent-api (mean:4.455): 53.46
whonix-workstation-17_dom0-dispvm-preload-less-less-api (mean:4.647): 55.76
whonix-workstation-17_dom0-dispvm-preload-less-api (mean:4.666): 55.99
whonix-workstation-17_dom0-dispvm-preload-api (mean:4.276): 51.31
whonix-workstation-17_dom0-dispvm-preload-more-api (mean:4.659): 55.91
whonix-workstation-17_dom0-dispvm-preload-more-more-api (mean:4.413): 52.96
whonix-workstation-17_dom0-dispvm-preload-gui-api (mean:5.393): 64.72
whonix-workstation-17_dom0-dispvm-preload-concurrent-api (mean:3.921): 47.05
whonix-workstation-17_dom0-dispvm-preload-gui-concurrent-api (mean:4.558): 54.70
whonix-workstation-17_vm-vm (mean:0.031): 0.37
whonix-workstation-17_vm-vm-gui (mean:0.049): 0.59
whonix-workstation-17_vm-vm-concurrent (mean:0.022): 0.26
whonix-workstation-17_vm-vm-gui-concurrent (mean:0.021): 0.25
whonix-workstation-17_dom0-vm-api (mean:0.041): 0.50
whonix-workstation-17_dom0-vm-gui-api (mean:0.036): 0.44
whonix-workstation-17_dom0-vm-concurrent-api (mean:0.027): 0.32
whonix-workstation-17_dom0-vm-gui-concurrent-api (mean:0.031): 0.37

marmarek · 2025-09-17T09:14:51Z

both test failed, with different message this time:

# timestamp 2025-09-17T07:19:24.165277
Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/qubes/tests/integ/backup.py", line 201, in make_backup
    backup = qubes.backup.Backup(self.app, vms, **kwargs)
  File "/usr/lib/python3.13/site-packages/qubes/backup.py", line 399, in __init__
    self._files_to_backup = self.get_files_to_backup()
                            ~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/qubes/backup.py", line 461, in get_files_to_backup
    raise qubes.exc.QubesException(
        "Can not backup dom0 home directory to itself!"
    )
qubes.exc.QubesException: Can not backup dom0 home directory to itself!

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib64/python3.13/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/usr/lib/python3.13/site-packages/qubes/tests/integ/backup.py", line 575, in test_100_backup_dom0_no_restore
    self.make_backup([self.app.domains[0]])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/qubes/tests/integ/backup.py", line 204, in make_backup
    self.fail("QubesException during backup_prepare: %s" % str(e))
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: QubesException during backup_prepare: Can not backup dom0 home directory to itself!

alimirjamali · 2025-09-17T10:36:53Z

both test failed, with different message this time:

Applied the fix.

marmarek · 2025-09-18T21:42:57Z

qubes/backup.py

            home_dir = pwd.getpwnam(local_user).pw_dir
+
+            # Checking if target is not user home directory in dom0
+            if self.target_dir in ["", "~", None] \


Based on earlier error, None shouldn't actually be refused, as it doesn't really mean to backup into user home - it means you don't know where is the target.

That is also done. But I believe in practice, None is never passed to qubes.backup.Backup constructor as the value of target directory. Since the Admin API always expects presence of target directory here.

resolves: QubesOS/qubes-issues#10127

alimirjamali · 2025-09-25T22:28:36Z

openQA failed again. I had to pass except_failure=True to make_backup

alimirjamali force-pushed the issue-10127-backup-dom0 branch 2 times, most recently from 1c00d73 to 8f742cb Compare September 11, 2025 18:52

alimirjamali force-pushed the issue-10127-backup-dom0 branch from 8f742cb to 273b5a9 Compare September 11, 2025 19:32

marmarek added the openqa-pending label Sep 15, 2025

alimirjamali force-pushed the issue-10127-backup-dom0 branch from 273b5a9 to 15b16b7 Compare September 15, 2025 20:43

alimirjamali force-pushed the issue-10127-backup-dom0 branch from 15b16b7 to 5a29ecc Compare September 17, 2025 10:34

marmarek reviewed Sep 18, 2025

View reviewed changes

alimirjamali force-pushed the issue-10127-backup-dom0 branch from e802ee9 to c21b307 Compare September 18, 2025 22:42

alimirjamali requested a review from marmarek September 18, 2025 22:49

qubesos-bot mentioned this pull request Sep 19, 2025

Skip preloads and dom0 on unpause all action QubesOS/qubes-desktop-linux-manager#277

Merged

alimirjamali force-pushed the issue-10127-backup-dom0 branch 4 times, most recently from 0a93398 to 199aafa Compare September 19, 2025 07:42

ben-grande mentioned this pull request Sep 19, 2025

Use failure name as upload failure can be empty QubesOS/openqa-tests-qubesos#42

Merged

alimirjamali force-pushed the issue-10127-backup-dom0 branch 5 times, most recently from 98a9903 to 6f4fa7c Compare September 19, 2025 13:37

This was referenced Sep 25, 2025

Fix for sysmaint systems (Whonix & Kicksecure) QubesOS/qubes-app-shutdown-idle#26

Merged

Switch dom0 dnf config to dnf5 QubesOS/qubes-core-admin-linux#202

Merged

Prevent backing up dom0 to itself (in home dir)

301e66f

resolves: QubesOS/qubes-issues#10127

alimirjamali force-pushed the issue-10127-backup-dom0 branch from 6f4fa7c to 301e66f Compare September 25, 2025 22:27

marmarek approved these changes Oct 4, 2025

View reviewed changes

marmarek merged commit fcdad08 into QubesOS:main Oct 4, 2025
2 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Prevent backing up dom0 it itself (in home dir) #731

Prevent backing up dom0 it itself (in home dir) #731

Uh oh!

alimirjamali commented Sep 11, 2025

Uh oh!

codecov bot commented Sep 11, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Sep 15, 2025 •

edited

Loading

Uh oh!

marmarek commented Sep 17, 2025

Uh oh!

alimirjamali commented Sep 17, 2025

Uh oh!

marmarek Sep 18, 2025

Uh oh!

alimirjamali Sep 18, 2025

Uh oh!

alimirjamali commented Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Prevent backing up dom0 it itself (in home dir) #731

Prevent backing up dom0 it itself (in home dir) #731

Uh oh!

Conversation

alimirjamali commented Sep 11, 2025

Uh oh!

codecov bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

marmarek commented Sep 17, 2025

Uh oh!

alimirjamali commented Sep 17, 2025

Uh oh!

marmarek Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

alimirjamali Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

alimirjamali commented Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Sep 11, 2025 •

edited

Loading

qubesos-bot commented Sep 15, 2025 •

edited

Loading