- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 56
Switch dom0 dnf config to dnf5 #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   72.98%   72.98%           
=======================================
  Files          10       10           
  Lines        1155     1155           
=======================================
  Hits          843      843           
  Misses        312      312           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| dnf5 finally supports config drop-ins, so it's much better to replace the whole dnf.conf patching with simply adding a config file in  | 
| 
 That is OK. But the patch would be only useful for Qubes OS r4.3 I will readjust it. | 
| 
 Yes, and the issue you are fixing applies to R4.3 only, R4.2 (fc37) has /etc/dnf/dnf.conf owned by the dnf-data package. | 
bbba25f    to
    526ea60      
    Compare
  
    | 
 This is ready | 
| 
 CI says no... | 
d94ff12    to
    facfad3      
    Compare
  
    | 
 CI is green again. | 
facfad3    to
    ea1424d      
    Compare
  
    | OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025100312-4.3&flavor=pull-requests Test run included the following: 
 New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update 
 Failed tests8 failures
 Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 83 fixed
 Unstable testsPerformance TestsPerformance degradation:15 performance degradations
 Remaining performance tests:165 tests
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The protect-... config name by convention is used to extend protected_packages list. This should be rather qubes.conf or even better 20-qubes-dom0.conf
ea1424d    to
    0e0c9e8      
    Compare
  
    | 
 This is done | 
Also drop yum. It is not used anymore