Preload reader #721
Merged
Preload reader #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-grande
force-pushed
the
preload-reader
branch
2 times, most recently
from
e91aa29 to
c18342f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
==========================================
- Coverage 70.55% 70.35% -0.20%
==========================================
Files 61 61
Lines 13642 13679 +37
==========================================
- Hits 9625 9624 -1
- Misses 4017 4055 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
preload-reader
branch
2 times, most recently
from
eef0a88 to
1e316c2
Compare
|
Hum, got very different results after the computer has been suspend... I will be updating the sample data soon. |
|
If that's on Novacustom laptop, it could be a side effect of QubesOS/qubes-issues#10110. See comments there for a workaround, and check if you still see a difference. |
ben-grande
force-pushed
the
preload-reader
branch
6 times, most recently
from
2ccf36a to
50affc4
Compare
32 tasks
ben-grande
force-pushed
the
preload-reader
branch
8 times, most recently
from
18fc3b7 to
2d5804b
Compare
ben-grande
commented
Sep 9, 2025
| pretty_name += "{}".format(pretty_to) | ||
| if pretty_type: | ||
| pretty_name += " ({})".format(pretty_type) | ||
| self.pretty_name = pretty_name |
There was a problem hiding this comment.
@marmarta Can you please check what you think of these names?
[user@dev ~/src/contrib/qubes-core-admin(preload-reader)]
% cd tests; PYTHONPATH=~/src/contrib/qubes-core-admin-client python3 -c 'import dispvm_perf; tests = dispvm_perf.ALL_TESTS; [print(test.pretty_name) for test in tests];'; cd -;Qube runs simple app in another running qube (qrexec-client-vm)
Qube runs GUI app in another running qube (qrexec-client-vm)
Qube runs 4 concurrent simple apps in another running qube (qrexec-client-vm)
Qube runs 4 concurrent GUI apps in another running qube (qrexec-client-vm)
Dom0 runs simple app in another running qube (API)
Dom0 runs GUI app in another running qube (API)
Dom0 runs 4 concurrent simple apps in another running qube (API)
Dom0 runs 4 concurrent GUI apps in another running qube (API)
Qube runs simple app in a disposable (qrexec-client-vm)
Qube runs GUI app in a disposable (qrexec-client-vm)
Qube runs 4 concurrent simple apps in disposables (qrexec-client-vm)
Qube runs 4 concurrent GUI apps in disposables (qrexec-client-vm)
Dom0 runs simple app in a disposable (qvm-run)
Dom0 runs GUI app in a disposable (qvm-run)
Dom0 runs 4 concurrent simple apps in disposables (qvm-run)
Dom0 runs 4 concurrent GUI apps in disposables (qvm-run)
Qube runs simple app in disposables (2 preloaded) (qrexec-client-vm)
Qube runs GUI app in disposables (2 preloaded) (qrexec-client-vm)
Qube runs 4 concurrent simple apps in disposables (4 preloaded) (qrexec-client-vm)
Qube runs 4 concurrent GUI apps in disposables (4 preloaded) (qrexec-client-vm)
Dom0 runs simple app in disposables (2 preloaded) (qvm-run)
Dom0 runs GUI app in disposables (2 preloaded) (qvm-run)
Dom0 runs 4 concurrent simple apps in disposables (4 preloaded) (qvm-run)
Dom0 runs 4 concurrent GUI apps in disposables (4 preloaded) (qvm-run)
Dom0 runs simple app in a disposable (API)
Dom0 runs 4 concurrent simple apps in disposables (API)
Dom0 runs GUI app in a disposable (API)
Dom0 runs 4 concurrent GUI apps in disposables (API)
Dom0 runs simple app in disposables (3 preloaded) (API)
Dom0 runs simple app in disposables (1 preloaded) (API)
Dom0 runs simple app in disposables (2 preloaded) (API)
Dom0 runs 4 concurrent simple apps in disposables (4 preloaded) (API)
Dom0 runs GUI app in disposables (2 preloaded) (API)
Dom0 runs 4 concurrent GUI apps in disposables (4 preloaded) (API)
There was a problem hiding this comment.
love it. Clear and understandable.
ben-grande
force-pushed
the
preload-reader
branch
4 times, most recently
from
1e60e74 to
8109b3d
Compare
ben-grande
force-pushed
the
preload-reader
branch
2 times, most recently
from
496dd5c to
85d7e32
Compare
This was referenced Oct 1, 2025
When running it as part of test_900_reader, do specify which template to do graphs for - the one that just had the perf tests completed. |
|
But when it did find correct template, it failed on one graph: |
This is because this test failed: https://openqa.qubes-os.org/tests/154722#step/TC_00_DispVMPerf_debian-13-xfce/26 So it is missing a preload for the debian template, then it can't load that graph correctly. What is the expected behavior here? I am doing changes to make it fail the graph but raise it late, to allow for other graphs such as |
ben-grande
force-pushed
the
preload-reader
branch
2 times, most recently
from
f6dcef3 to
a646f4a
Compare
|
The exception is not great right now because it will only report one exception even if more graphs fail... will fix it. |
Yes, try to make other graphs anyway. A better error message would be useful too, but I guess that may be tricky if only some parts of the data is missing... |
|
BTW I like you made the reader script taking just the data file as input, not needing (or even importing) qubes api so it can be run outside of qubes dom0 too :) |
ben-grande
force-pushed
the
preload-reader
branch
3 times, most recently
from
65d90b9 to
c6e10ea
Compare
|
On a test that I removed a fedora test and used debian as the default template, the next graph was loaded. |
|
This is a bit unfortunate: So, one debian test failed, which caused errors on all reader test - as 08_template include data from all templates... But I don't have any better idea how to handle that. |
This was referenced Oct 3, 2025
I think the graph should fail, but at least, save the figure: It requires reworking the code a bit. |
|
ben-grande
force-pushed
the
preload-reader
branch
from
c6e10ea to
cc3a140
Compare
marmarek
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visualization of disposable and preload performance compared to vm-vm connections.
There are lot of todos, not ready to be merged...