Add HS4xD support #56683

kokas-a · 2023-04-10T12:32:21Z

Minimal HSDK4xD support

kokas-a · 2023-04-12T17:37:57Z

@evgeniy-paltsev Could you please take a look? PR has same issues with checks, but it wold be nice to have your feedback on key points

arch/arc/core/reset.S

arch/arc/Kconfig

arch/arc/core/reset.S

boards/arc/hsdk4xd/CMakeLists.txt

soc/arc/snps_arc_hsdk4xd/CMakeLists.txt

arch/arc/core/reset.S

boards/arc/hsdk4xd/support/openocd.cfg

soc/arc/snps_arc_hsdk4xd/CMakeLists.txt

arch/arc/Kconfig

arch/arc/core/dsp/Kconfig

arch/arc/core/dsp/swap_dsp_macros.h

soc/arc/snps_arc_hsdk4xd/soc_ctrl.h

evgeniy-paltsev · 2023-04-26T20:46:06Z

dts/arc/synopsys/arc_hs4xd.dtsi

I'm wondering if this is still related to some issue?

evgeniy-paltsev · 2023-04-27T13:13:41Z

soc/arc/snps_arc_hsdk4xd/CMakeLists.txt

Suggested change

zephyr_compile_options(-arcv2hs -core4 -Xdual_issue -Xcode_density -Hrgf_banked_regs=32 -HL

-Xatomic -Xll64 -Xunaligned -Xdiv_rem=radix4 -Xswap -Xbitscan -Xmpy_option=qmpyh -Xshift_assist

-Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc -Hld_cycles=2 -Xlpb_size=128)

zephyr_compile_options(-arcv2hs -core4 -Xdual_issue -Xcode_density -Hrgf_banked_regs=32 -HL

-Xatomic -Xll64 -Xunaligned -Xdiv_rem=radix4 -Xswap -Xbitscan -Xmpy_option=qmpyh -Xshift_assist

-Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc -Hld_cycles=2)

Alignment fix and drop Xlpb_size as we disable LPB anyway.

evgeniy-paltsev · 2023-04-27T13:14:35Z

soc/arc/snps_arc_hsdk4xd/linker.ld

Suggested change

#if DT_NODE_HAS_PROP(DT_CHOSEN(zephyr_sram), reg) && \

(DT_REG_SIZE(DT_CHOSEN(zephyr_sram)) > 0)

#if DT_NODE_HAS_PROP(DT_CHOSEN(zephyr_sram), reg) && (DT_REG_SIZE(DT_CHOSEN(zephyr_sram)) > 0)

This fits to 100 character per line limit.

evgeniy-paltsev · 2023-04-27T13:20:27Z

arch/arc/Kconfig

I'd rephrase it to:

Call SoC per-core setup code on early stage initialization (before C runtime initialization). Setup code is called in form of soc_early_asm_init_percpu assembler macro.

nordicjm · 2023-04-27T15:10:58Z

cmake/gcc-m-cpu.cmake

Can you add this to https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/mgmt/mcumgr/grp/os_mgmt/include/os_mgmt_processor.h as a separate commit?

Done: #57348

abrodkin

A couple of minor notes below. And what about documentation update or maybe even a separate docs page for that board?

abrodkin · 2023-04-28T10:19:10Z

arch/arc/Kconfig

satge -> stage

boards/arc/hsdk4xd/Kconfig.defconfig

evgeniy-paltsev · 2023-04-28T17:50:21Z

boards/arc/hsdk4xd/Kconfig.board

This is also shouldn't be just a TODO.

Minimal HSDK4xD support Signed-off-by: Nikolay Agishev <[email protected]>

ruuddw · 2023-05-02T13:32:30Z

arch/arc/core/reset.S

+	soc_early_asm_init_percpu
+#endif
+
+	_dsp_extension_probe


Can you explain this dsp_extension__probe (and the CONFIG_DSP_TURNED_OFF) more?
The 'probe' name implies it is testing if the DSP extension is present or not, but the implementation and comments say it is turning off DSP.
Is the mechanism for turning off DSP generic for ARC? does it work on EM as well? If not, maybe move this to the SOC specific early_soc_init instead of this generic reset.S module.

Initially the macro looked like:

.macro _dsp_extension_probe lr r0, [_ARC_V2_DSP_BUILD] bmsk r0, r0, 7 breq r0, 0, skip_dsp_setup #ifdef CONFIG_ARC_DSP_TURNED_OFF mov r0, 0 /* DSP_CTRL_DISABLED_ALL */ sr r0, [_ARC_V2_DSP_CTRL] #endif skip_dsp_setup : .endm

After all stages of review it turned into what you may see. Indeed, in current state it's more appropriate to move it into early_soc_init.

I see it was already merged. Please do so in a follow-up PR (this was minimal enablement only, anyway, and documentation is missing).
Does writing 0 to DSP_CTRL really 'turn DSP off"? Or just initializes some control flags?

DSP_CTRL does not really turn off DSP. Writing 0 disables some DSP features

Thanks for confirming, that's what I remembered. So, not only the 'probe' but also the "DSP_TURNED_OFF" should be renamed. Actually, I don't think we need a kconfig option for that, it is just standard initialization.

kokas-a force-pushed the arc_hs4x branch 7 times, most recently from 8455a43 to e37e29b Compare April 12, 2023 14:46

evgeniy-paltsev requested changes Apr 12, 2023

View reviewed changes

arch/arc/core/reset.S Outdated Show resolved Hide resolved

evgeniy-paltsev requested changes Apr 12, 2023

View reviewed changes

arch/arc/Kconfig Outdated Show resolved Hide resolved

arch/arc/Kconfig Outdated Show resolved Hide resolved

arch/arc/core/reset.S Outdated Show resolved Hide resolved

evgeniy-paltsev requested changes Apr 12, 2023

View reviewed changes

boards/arc/hsdk4xd/CMakeLists.txt Outdated Show resolved Hide resolved

soc/arc/snps_arc_hsdk4xd/CMakeLists.txt Outdated Show resolved Hide resolved

kokas-a force-pushed the arc_hs4x branch 5 times, most recently from 9d3ad81 to 1218bbb Compare April 17, 2023 12:39

kokas-a requested a review from evgeniy-paltsev April 17, 2023 13:43

evgeniy-paltsev reviewed Apr 17, 2023

View reviewed changes

arch/arc/core/reset.S Outdated Show resolved Hide resolved

arch/arc/core/reset.S Outdated Show resolved Hide resolved

boards/arc/hsdk4xd/support/openocd.cfg Outdated Show resolved Hide resolved

kokas-a force-pushed the arc_hs4x branch from 1218bbb to e1aa364 Compare April 17, 2023 15:32

kokas-a requested a review from evgeniy-paltsev April 18, 2023 10:57

kokas-a force-pushed the arc_hs4x branch from e1aa364 to 60daefc Compare April 19, 2023 08:02

evgeniy-paltsev reviewed Apr 20, 2023

View reviewed changes

soc/arc/snps_arc_hsdk4xd/CMakeLists.txt Outdated Show resolved Hide resolved

arch/arc/Kconfig Outdated Show resolved Hide resolved

arch/arc/Kconfig Outdated Show resolved Hide resolved

arch/arc/Kconfig Outdated Show resolved Hide resolved

kokas-a force-pushed the arc_hs4x branch from 60daefc to a7ba653 Compare April 21, 2023 10:06

kokas-a requested a review from evgeniy-paltsev April 21, 2023 11:20

kokas-a force-pushed the arc_hs4x branch from a7ba653 to fff5102 Compare April 26, 2023 15:42

evgeniy-paltsev requested changes Apr 26, 2023

View reviewed changes

arch/arc/core/dsp/Kconfig Outdated Show resolved Hide resolved

arch/arc/core/dsp/swap_dsp_macros.h Outdated Show resolved Hide resolved

soc/arc/snps_arc_hsdk4xd/soc_ctrl.h Outdated Show resolved Hide resolved

evgeniy-paltsev reviewed Apr 26, 2023

View reviewed changes

dts/arc/synopsys/arc_hs4xd.dtsi Outdated

Copy link

Contributor

evgeniy-paltsev Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this is still related to some issue?

kokas-a force-pushed the arc_hs4x branch from fff5102 to 66479d8 Compare April 27, 2023 09:23

evgeniy-paltsev requested changes Apr 27, 2023

View reviewed changes

kokas-a force-pushed the arc_hs4x branch from 66479d8 to 139821b Compare April 27, 2023 14:00

kokas-a requested review from nashif and tejlmand as code owners April 27, 2023 15:07

kokas-a requested a review from evgeniy-paltsev April 27, 2023 15:07

zephyrbot added platform: Synopsys Synopsys area: ARC ARC Architecture area: Build System labels Apr 27, 2023

zephyrbot requested review from SiyuanCheng-CN, jeremybettis and nordicjm April 27, 2023 15:08

zephyrbot assigned ruuddw Apr 27, 2023

nordicjm reviewed Apr 27, 2023

View reviewed changes

kokas-a mentioned this pull request Apr 27, 2023

ARC: Add hs4x processor to os_mgmt_processor list #57348

Closed

kokas-a force-pushed the arc_hs4x branch from 8d5aa10 to ee4625a Compare April 27, 2023 15:39

kokas-a requested review from carlescufi and de-nordic as code owners April 27, 2023 15:39

zephyrbot added the area: mcumgr label Apr 27, 2023

abrodkin requested changes Apr 28, 2023

View reviewed changes

arch/arc/Kconfig Outdated

Copy link

Contributor

abrodkin Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

satge -> stage

boards/arc/hsdk4xd/Kconfig.defconfig Outdated Show resolved Hide resolved

kokas-a force-pushed the arc_hs4x branch from ee4625a to 34ad8c7 Compare April 28, 2023 12:28

kokas-a requested review from abrodkin and nordicjm April 28, 2023 13:49

evgeniy-paltsev reviewed Apr 28, 2023

View reviewed changes

boards/arc/hsdk4xd/Kconfig.board Outdated

Comment on lines 9 to 10

Copy link

Contributor

evgeniy-paltsev Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also shouldn't be just a TODO.

ARC: Add HS4x support

e784535

Minimal HSDK4xD support Signed-off-by: Nikolay Agishev <[email protected]>

kokas-a force-pushed the arc_hs4x branch from 34ad8c7 to e784535 Compare May 1, 2023 08:34

kokas-a mentioned this pull request May 1, 2023

ARC: HSDK4XD: Add basic peripheral devices support #57430

Closed

kokas-a requested a review from evgeniy-paltsev May 1, 2023 09:35

abrodkin approved these changes May 2, 2023

View reviewed changes

ruuddw reviewed May 2, 2023

View reviewed changes

evgeniy-paltsev approved these changes May 2, 2023

View reviewed changes

carlescufi merged commit 0d8292a into zephyrproject-rtos:main May 2, 2023

kokas-a mentioned this pull request May 12, 2023

Add support for HS4XD SoC foss-for-synopsys-dwc-arc-processors/zephyr#6

Closed

-   zephyr_compile_options(-arcv2hs -core4 -Xdual_issue -Xcode_density -Hrgf_banked_regs=32 -HL
-    -Xatomic -Xll64 -Xunaligned -Xdiv_rem=radix4 -Xswap -Xbitscan -Xmpy_option=qmpyh -Xshift_assist
-    -Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc -Hld_cycles=2 -Xlpb_size=128)
+  zephyr_compile_options(-arcv2hs -core4 -Xdual_issue -Xcode_density -Hrgf_banked_regs=32 -HL
+    -Xatomic -Xll64 -Xunaligned -Xdiv_rem=radix4 -Xswap -Xbitscan -Xmpy_option=qmpyh -Xshift_assist
+    -Xbarrel_shifter -Xtimer0 -Xtimer1 -Xrtc -Hld_cycles=2)

	#if DT_NODE_HAS_PROP(DT_CHOSEN(zephyr_sram), reg) && \
	(DT_REG_SIZE(DT_CHOSEN(zephyr_sram)) > 0)
	#if DT_NODE_HAS_PROP(DT_CHOSEN(zephyr_sram), reg) && (DT_REG_SIZE(DT_CHOSEN(zephyr_sram)) > 0)

Add HS4xD support #56683

Add HS4xD support #56683

Uh oh!

Conversation

kokas-a commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kokas-a commented Apr 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abrodkin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kokas-a commented Apr 10, 2023 •

edited

Loading