Add support for HS4XD SoC #6

kokas-a · 2022-10-12T14:35:21Z

Add set of initial files for HS4XD SoC support. Based on HSDK sources.

evgeniy-paltsev

Some minor issues.

I'll check how this implementation maps to current DSP support for EM development - probably we can combine dsp implementations.

evgeniy-paltsev · 2022-10-12T21:40:19Z

boards/arc/hs4xd/hs4xd_defconfig

+CONFIG_SOC_ARC_HS4XD=y
+CONFIG_BOARD_HS4XD=y
+CONFIG_SYS_CLOCK_TICKS_PER_SEC=100
+CONFIG_XIP=y


Any reason to have XIP enabled?

We don't have any XIP flash memory and we don't have XIP enabled for HSDK v1.

evgeniy-paltsev · 2022-10-12T21:40:48Z

soc/arc/snps_arc_hs4xd/Kconfig.defconfig

+if SOC_ARC_HS4XD
+
+config SOC
+	default "snps_arc_hs4xd"


snps_arc_hs4xd -> snps_arc_hsdk4xd

SoC based on HS4x core. "DK" as I understand means "Development Kit". Is it correct name SoC with "DK" abbreviation?

evgeniy-paltsev · 2022-10-12T21:43:54Z

boards/arc/hs4xd/Kconfig.defconfig

+if BOARD_HS4XD
+
+config BOARD
+	default "hs4xd"


hs4xd -> hsdk4xd

evgeniy-paltsev · 2022-10-12T21:44:43Z

boards/arc/hs4xd/Kconfig.board

@@ -0,0 +1,10 @@
+# DesignWare ARC HS4XD Development Kit board configuration


HS4XD -> HSDK4xD

evgeniy-paltsev · 2022-10-12T21:45:23Z

boards/arc/hs4xd/Kconfig.board

+# Copyright (c) 2022 Synopsys, Inc. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+
+config BOARD_HS4XD


BOARD_HS4XD -> BOARD_HSDK4XD

evgeniy-paltsev · 2022-10-12T21:46:28Z

soc/arc/snps_arc_hs4xd/soc.c

@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2019 Synopsys, Inc. All rights reserved.


evgeniy-paltsev · 2022-10-12T21:48:22Z

soc/arc/snps_arc_hs4xd/soc.c

+	uint32_t core;
+	uint32_t i;
+
+	/* allocate all IDU interrupts to master core */


master -> primary

evgeniy-paltsev · 2022-10-12T21:49:41Z

soc/arc/snps_arc_hs4xd/soc.c

+ * This module provides routines to initialize and support soc-level hardware
+ * for the HS Development Kit


Copypaste, please update board name

evgeniy-paltsev · 2022-10-12T21:50:19Z

soc/arc/snps_arc_hs4xd/Kconfig.soc

@@ -0,0 +1,8 @@
+# Copyright (c) 2019 Synopsys, Inc. All rights reserved.


evgeniy-paltsev · 2022-10-12T21:51:15Z

boards/arc/hs4xd/hs4xd.dts

+
+/dts-v1/;
+
+#include "hs4xd.dtsi"


hs4xd.dtsi -> hsdk4xd.dtsi

ruuddw · 2022-10-13T08:47:27Z

Few questions:

Do we need a new CPU type for this? HS4x is already covered with the CPU_HS3X option. "If y, the SoC uses an ARC HS3x or HS4x CPU". There is no HS3XD either, it is simply configured by enabling 'DSP' for the HS3X
Do we need a new board? Is there a physical board for this, or is it another config of nsim/qemu?

evgeniy-paltsev · 2022-10-13T09:09:58Z

Hi @ruuddw,

Do we need a new CPU type for this? HS4x is already covered with the CPU_HS3X option. "If y, the SoC uses an ARC HS3x or HS4x CPU". There is no HS3XD either, it is simply configured by enabling 'DSP' for the HS3X

I'm not fully sure about this. The one meaningful part of having CPU_HS4X is to provide generic hs4x mcpu for all GNU toolchain targets (it's currently missing in this PR). However, as we have now possibility to tweak mcpu on SoC level - that might be a bit excessive :)

And yep, if we introduce new cpu it should be CPU_HS4X + DSP option enabled and not CPU_HS4XD as we have now.

Do we need a new board? Is there a physical board for this, or is it another config of nsim/qemu?

Yep, it's physical board.
See "ARC HS4x/HS4xD Development Kit" section on https://www.synopsys.com/dw/ipdir.php?ds=arc-hs-development-kit page

ruuddw · 2022-10-13T10:00:54Z

I considered the HSDK a single board, but you're right there are two revisions. Doesn't the existing HSDK cover both revisions?
Still (I think I mentioned this at that time), using CPU_HS3x for either 3X or 4X is confusing, so I don't mind adding 4X explicitly. But let's be consistent on the "D" as option and not a main CPU.

abrodkin · 2023-05-12T11:06:13Z

@kokas-a care to add a reference to the upstream PR which implements it?

kokas-a · 2023-05-12T12:02:58Z

HS4XD support was added to upstream by PR zephyrproject-rtos#56683

kokas-a requested review from abrodkin, evgeniy-paltsev and ruuddw as code owners October 12, 2022 14:35

evgeniy-paltsev requested changes Oct 12, 2022

View reviewed changes

Add HS4xD support

280819c

kokas-a force-pushed the arc_qemu_hs4xd_separate branch from bfa37e8 to 280819c Compare April 10, 2023 07:00

kokas-a closed this May 12, 2023

		@@ -0,0 +1,10 @@
		# DesignWare ARC HS4XD Development Kit board configuration

		@@ -0,0 +1,39 @@
		/*
		* Copyright (c) 2019 Synopsys, Inc. All rights reserved.

		* This module provides routines to initialize and support soc-level hardware
		* for the HS Development Kit

		@@ -0,0 +1,8 @@
		# Copyright (c) 2019 Synopsys, Inc. All rights reserved.


		/dts-v1/;

		#include "hs4xd.dtsi"

Add support for HS4XD SoC #6

Add support for HS4XD SoC #6

Uh oh!

Conversation

kokas-a commented Oct 12, 2022

Uh oh!

evgeniy-paltsev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ruuddw commented Oct 13, 2022

Uh oh!

evgeniy-paltsev commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ruuddw commented Oct 13, 2022

Uh oh!

abrodkin commented May 12, 2023

Uh oh!

kokas-a commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

evgeniy-paltsev commented Oct 13, 2022 •

edited

Loading