Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Always filter attribute filters based on price filter #1390

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Always filter attribute filters based on price filter #1390

merged 1 commit into from
Dec 16, 2019

Conversation

@Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Dec 16, 2019

Fixes #1380.

Screenshots

Peek 2019-12-16 12-00

How to test the changes in this Pull Request:

  1. Create a post with All Products + Price Filter + Attribute Filter (with OR as query type).
  2. Verify when you select attributes filters, others don't disappear (so there are no regressions since Avoid filtering Attribute Filter options when query type is OR #1339).
  3. Verify when you update the price slider, attribute filters update and the ones not matching disappear.

Changelog

Fix: Attribute filters were not updating based on changes in the Price filter when query type was set to OR.

@Aljullu Aljullu added status: needs review type: bug The issue/PR concerns a confirmed bug. labels Dec 16, 2019
@Aljullu Aljullu added this to the 2.5.5 milestone Dec 16, 2019
@Aljullu Aljullu requested a review from a team December 16, 2019 11:01
@Aljullu Aljullu self-assigned this Dec 16, 2019
nerrad
nerrad approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix (also like the variable name change)! :shipit:

@Aljullu Aljullu merged commit 329054c into master Dec 16, 2019
@Aljullu Aljullu deleted the fix/1380-filter-attributes-based-on-price branch December 16, 2019 13:04
@senadir senadir added the release: cherry-pick Cherry picked into the relevant release branch. label Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nerrad nerrad nerrad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Aljullu Aljullu

Labels

release: cherry-pick Cherry picked into the relevant release branch. type: bug The issue/PR concerns a confirmed bug.

Projects

None yet

Milestone

2.5.5

Development

Successfully merging this pull request may close these issues.

[WC 3.9 beta1]: price slider shows wrong values when activating an attribute filter which is not in current price range

5 participants

@Aljullu @nerrad @senadir @woocommercebot