Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Conversation

@Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Dec 6, 2019

Fixes #1338.

Note: this was fixed in master in #1309, so there is no need to cherry-pick this PR.

Screenshots

Options should only be hidden when Query Type is AND:
Peek 2019-12-03 17-50

How to test the changes in this Pull Request:

  1. Create a post with a Filter Products by Attribute block and set Query Type to OR.
  2. Preview the post and check one of the options.
  3. Verify other options don't disappear.

Changelog

Prevent Filter Products by Attribute block hiding non-matching options when Querty Type is set to OR.

@Aljullu Aljullu added this to the 2.5.3 milestone Dec 6, 2019
@Aljullu Aljullu requested a review from a team December 6, 2019 14:00
@Aljullu Aljullu self-assigned this Dec 6, 2019
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work okay! One thing I am wondering about though:

  • this seems like something that should be able to optionally be exposed to the potential customer to choose how the filtering applies. There's no ui/ux indicators that indicate what type of query is being done. Should there be?
  • The active filter doesn't distinguish the type of filtering being done and that may be a place where it can be indicated.

Both the above are things that probably should have follow-up issues created (and not necessary for 2.5.x release).

@Aljullu
Copy link
Contributor Author

Aljullu commented Dec 6, 2019

Agree @nerrad! I created two issues: #1340 and #1341 to track it.

@Aljullu Aljullu merged commit 39db2ea into release/2.5 Dec 6, 2019
@Aljullu Aljullu deleted the fix/1338-dont-filter-attributes-or branch December 6, 2019 15:07
@mikejolley mikejolley added the release: cherry-pick Cherry picked into the relevant release branch. label Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release: cherry-pick Cherry picked into the relevant release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants