-
Notifications
You must be signed in to change notification settings - Fork 13
For publication / deploy on Tuesday September 30, 2025 #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added script to pr-create.yml to reinit submodules to avoid stale references if any exist
Fix merge conflicts in submodule when `pr-create` runs
# Conflicts: # .gitmodules # ARIA/apg/patterns/feed/examples/feed.md # _external/aria-practices
# Conflicts: # ARIA/apg/patterns/patterns.md # ARIA/apg/practices/practices.md # _external/aria-practices # content-assets/wai-aria-practices/shared/js/read-this-first.js
Sources "Read This First, No ARIA is better than Bad ARIA" banner from APG
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shawna-slh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From quick skim, looks OK to me. Rémi will take it from here...
| <div class="note"> | ||
| <h4>Note</h4> | ||
| <p>This guidance focuses specifically on keyboard interaction. However, authors must of course also consider pointer interactions, such as mouse clicks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be improved. We are putting must in a note, which in itself is confusing. Also, the of course here is redundant, so can be avoided.
| <p>This guidance focuses specifically on keyboard interaction. However, authors must of course also consider pointer interactions, such as mouse clicks | |
| <p>This guidance focuses specifically on keyboard interaction. However, authors also need to consider pointer interactions, such as mouse clicks |
|
Sorry @howard-e I just pressed the button too quickly. For a follow-up PR on my requested changes, see w3c/aria-practices#3366 |
@daniel-montalvo thanks! I updated w3c/aria-practices#3366 title but this change seems good to me cc @mcking65 @a11ydoer, I requested both of your reviews on that to unblock this publication release |
|
@remibetin this is now ready for your review & publication. |
|
Hello @remibetin! Checking in again if there's anything else needed to move this to publication? |
|
@remibetin did talked about this to me this morning. Just logging it in here. Not a blocker for publication, but something for us to pick up for future fix. The "Read this first" banner is included using client-side JavaScript. It would be more elegant if we could use HTML or a jekyll _include |
|
@daniel-montalvo @howard-e Published and ready for your QA. |
Hi @shawna-slh and @remibetin. We would like to deploy a new version of the APG. This was approved during this week's APG meeting by @mcking65 and @daniel-montalvo.
The update includes the following, sourced from w3c/aria-practices 2025-09-17 September 2025 APG Publication Milestone and pushed to w3c/aria-practices
mainbranch:Developing a Keyboard Interface Practice: Editorial revision to note about pointer considerations (pull #3366)
By Daniel Montalvo on September 30, 2025
Makes two minor editorial improvements to the note about pointer considerations when managing focus:
View commit 2cafe96
Carousel Pattern: Fix inconsistency in use of digits and number words (pull #3362)
By Mehraz Morshed on September 17, 2025
Changed "slide one" (word form) to "slide 1" (digit form for consistency with other mentions of slide numbers.
View commit 59a55b3
Add "Quantity Spin Button" pattern example (pull #3328)
By Adam Page on September 17, 2025
Resolves #3261 by:
These changes also resolve issues #2241, #2238, #1837, #1655, and #1188.
Co-authored-by: Howard Edwards
Co-authored-by: Matt King
View commit 0234ae9
Grid Pattern: Correct error in description of left/right arrow behavior when navigating inside a cell (pull #3356)
By NakajimaTakuya on September 16, 2025
Documentation of wrapping behaviors when navigating among elements inside of a grid cell had the wrap-around behavior reversed. This commit corrects the error.
View commit 219f526
Developing a Keyboard Interface Practice: Add note about pointer activation and roving tabindex/aria-activedescendant (pull #3311)
By Patrick H. Lauke on September 16, 2025
Fixes #1710:
Adds a new note advising authors to change the roving tabindex or set the correct aria-activedescendant reference as a result of pointer interactions (clicks, taps, ...) as otherwise there will be a mismatch for users that navigate with both keyboard and pointer.
Also adds
<code> ... </code>around relevant words like tabindex and aria-activedescendant.Co-authored-by: Ariella Gilmore
View commit b5f2c69
Pattern Pages: Show link to "Read This First" just after the H1 on each pattern page (pull #3320)
By Howard Edwards on September 2, 2025
Resolves issue #3293 by including a link to the "Read This First" practice page at the top of every pattern page, immediately following the H1.
Includes an infrastructure update to move control of the read this first content display to the aria-practices content repository from the wai-aria-practices build repo.
View commit 457f47a
Editor Menubar Example: Fix tabindex management to ensure only the most recently opened menu is in the page tab sequence (pull #3309)
By Alec Mitnik on August 12, 2025
Fixes bugs where using a combination of keyboard and mouse interactions caused multiple menu items to be in the page Tab sequence.
The following changes ensure that only the most recently opened menu is the only menu item in the page tab sequence regardless of how that menu item was opened or had originally received focus:
View commit ccfa79e
All Pages: Change 'Javascript' to 'JavaScript' (pull #3306)
By Umair Khan on August 12, 2025
Standardize case of 'JavaScript' across content and templates.
Co-authored-by: Howard Edwards
View commit 8b05538