Sources "Read This First, No ARIA is better than Bad ARIA" banner from APG #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
howard-e
commented
Jul 28, 2025
.gitmodules
Outdated
| path = _external/aria-practices | ||
| url = https://github.com/w3c/aria-practices.git | ||
| branch = main | ||
| branch = read-this-first-at-source |
Contributor
Author
There was a problem hiding this comment.
Warning
Revert to main and run git submodule sync && git submodule update --init --recursive before merging once the related APG PR is merged
This was referenced Jul 30, 2025
# Conflicts: # .gitmodules # ARIA/apg/patterns/feed/examples/feed.md # _external/aria-practices
ChrisC
reviewed
Aug 19, 2025
ChrisC
approved these changes
Aug 19, 2025
# Conflicts: # ARIA/apg/patterns/patterns.md # ARIA/apg/practices/practices.md # _external/aria-practices # content-assets/wai-aria-practices/shared/js/read-this-first.js
Contributor
Author
|
w3c/aria-practices#3320 has now been merged. Moving forward with merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #411 (pulling previous description and discussion here)
Requires w3c/aria-practices#3320 also being reviewed and merged
Closes w3c/aria-practices#3293
This allows displaying a trimmed (img-less) version of the "Read This First, No ARIA is better than Bad ARIA. Before using any ARIA" banner to each pattern page.
Contrary to initial discussions when that meeting took place, this change had to happen here, rather than in w3c/aria-practices, because the "Read This First" banner is being injected during this repository's build process.
During's today's APG meeting, it was decided to move this injection away from the build repo to the content repo. Will re-purpose this PR to remove this injection here when that is ready.