Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
1828482
Source read-this-first and other template content directly from w3c/a…
howard-e Jul 28, 2025
a24ecb3
Update styles
howard-e Jul 28, 2025
ee92e6f
Add files after pre-build
howard-e Jul 28, 2025
91bcfa3
Update transform for updating read-this-first.js script as needed
howard-e Jul 30, 2025
03f973b
fix transformOtherAsset spacing
howard-e Jul 30, 2025
639cab9
Testing image with another path
howard-e Jul 30, 2025
0ce295e
Update transformOtherAsset to account for read-me-first url
howard-e Jul 30, 2025
b44f627
Update built files
howard-e Jul 30, 2025
6d38a4c
Update built files
howard-e Jul 30, 2025
56686f8
Update transformTemplate.js
howard-e Jul 30, 2025
20f7d0d
Update built files
howard-e Jul 30, 2025
792b6b4
Added script to reinit submodules to avoid stale references if any exist
howard-e Aug 5, 2025
164b85c
Added script to reinit submodules to avoid stale references if any exist
howard-e Aug 6, 2025
1b5249a
Merge pull request #426 from w3c/fix-unknown-refs-deploy
howard-e Aug 6, 2025
74a7204
Reset branch instead of attempting merge in submodule
howard-e Aug 6, 2025
af152a1
iteratively handle merge and rebase conflicts in pr-create
howard-e Aug 6, 2025
99594b6
Merge pull request #427 from w3c/fix-merge-conflict-in-submodule
howard-e Aug 6, 2025
f71f0ed
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Aug 12, 2025
74fa9b1
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Aug 12, 2025
785e975
Merge branch 'main' into read-this-first-at-source
howard-e Aug 19, 2025
45b17ca
Fix merge conflicts
howard-e Aug 19, 2025
71003f9
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Sep 2, 2025
c4ac250
Revert .gitmodules
howard-e Sep 2, 2025
7aa1329
Merge branch 'main' into read-this-first-at-source
howard-e Sep 2, 2025
431cdb8
Update following APG merge
howard-e Sep 2, 2025
b3a39f9
Merge pull request #422 from w3c/read-this-first-at-source
howard-e Sep 2, 2025
408b3a2
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Sep 2, 2025
aff069c
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Sep 16, 2025
eab5ab2
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Sep 16, 2025
43e4bec
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Sep 18, 2025
79469e0
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Sep 18, 2025
5e305f4
chore: Update `main` with latest changes from `aria-practices`
w3cgruntbot Sep 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 54 additions & 14 deletions .github/workflows/pr-create.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,26 @@ jobs:

- name: Update git submodules
run: |
# Deinit and reinit submodules
echo "Deinitializing existing submodules..."
git submodule deinit -f "_external/aria-practices" || true
git submodule deinit -f "_external/data" || true

# Remove stale directories
if [ -d "_external/aria-practices" ]; then
echo "Removing stale aria-practices directory..."
rm -rf "_external/aria-practices"
fi
if [ -d "_external/data" ]; then
echo "Removing stale data directory..."
rm -rf "_external/data"
fi

# Reinitialize submodules
echo "Initializing submodules..."
git submodule update --init --recursive

# Update from remote and handle fork if exists
git submodule update --recursive --remote
cd _external/aria-practices
if [ -n "${{ github.event.inputs.fork_path }}" ] && [ "${{ github.event.inputs.fork_path }}" != 'false' ]; then
Expand All @@ -69,32 +89,52 @@ jobs:

# Handle cases where the aria-practices submodule has conflicts to be handled;
# _external/data shouldn't have conflicting changes
if [ -d "_external/aria-practices" ] && { [ -f ".git/rebase-apply" ] || [ -d ".git/rebase-merge" ]; }; then
while { [ -f ".git/rebase-apply" ] || [ -d ".git/rebase-merge" ]; }; do
echo "Handling submodule conflicts..."
cd _external/aria-practices

# Resolve the conflict
git fetch origin
git merge origin/main
# Handle submodule conflicts first if they exist
if [ -d "_external/aria-practices" ]; then
echo "Checking for submodule conflicts..."
cd _external/aria-practices

# Add resolved submodule from project root
cd -
git add _external/aria-practices
# If submodule has conflicts, resolve them
if [ -f ".git/MERGE_HEAD" ] || [ -d ".git/rebase-merge" ] || [ -f ".git/rebase-apply" ]; then
echo "Resolving submodule conflicts..."
git fetch origin
git merge origin/main
fi

# Continue the rebase
GIT_EDITOR=true git rebase --continue || true
# Add resolved submodule from project root
cd -
git add _external/aria-practices
fi

# Resolve conflicts for all other conflicting files automatically using 'theirs' from project root
echo "Resolving file conflicts..."
git diff --name-only --diff-filter=U | while read -r file; do
echo "Resolving conflict in: $file"
git checkout --theirs "$file"
git add "$file"
done

# Continue the rebase
GIT_EDITOR=true git rebase --continue || true
else
echo "No submodule conflicts detected or no rebase in progress."
fi
echo "Continuing rebase..."
GIT_EDITOR=true git rebase --continue || {
echo "Rebase continue failed, checking if more conflicts exist..."
# If rebase failed, check if due to more conflicts
if { [ -f ".git/rebase-apply" ] || [ -d ".git/rebase-merge" ]; }; then
echo "More conflicts detected, continuing to resolve..."
continue
else
echo "Rebase completed or failed for other reasons"
break
fi
}

echo "Submodule conflicts fix step completed successfully"
done

echo "No submodule conflicts detected or no rebase in progress"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "_external/aria-practices"]
path = _external/aria-practices
url = https://github.com/w3c/aria-practices.git
branch = main
branch = main
[submodule "_external/data"]
path = _external/data
url = https://github.com/w3c/wai-website-data.git
2 changes: 1 addition & 1 deletion ARIA/apg/about/change-history/change-history.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ lang: en
<li>Improved support for high contrast settings and added detailed documentation of high contrast support in many examples.</li>
<li>Improved support for touch-based screen readers in several examples, most notably in sliders.</li>
<li>Due to change in ARIA 1.2, removed Math role from list of roles that have presentational children.</li>
<li>Developed a <a href="https://github.com/w3c/aria-practices/wiki/Code-Guide#apg-coding-standards">comprehensive set of coding standards for HTML, CSS, and Javascript</a> for the APG and updated a significant portion of content to conform with the standards.</li>
<li>Developed a <a href="https://github.com/w3c/aria-practices/wiki/Code-Guide#apg-coding-standards">comprehensive set of coding standards for HTML, CSS, and JavaScript</a> for the APG and updated a significant portion of content to conform with the standards.</li>
<li>In response to feedback, fixed many documentation errors and functional bugs in examples.</li>
</ul>
<p>Comprehensive lists of closed issues included in APG 1.2 release 1 are tracked in the following GitHub milestones.</p>
Expand Down
Loading